Fix hit point displacement calculation resulting from animation (#339)

msz-rai · web-flow · commit 756eb122997f · 2024-10-17T15:58:27.000+02:00
Remove unnecessary scale vector multiplication
diff --git a/src/gpu/optixPrograms.cu b/src/gpu/optixPrograms.cu
@@ -193,7 +193,7 @@ extern "C" __global__ void __closesthit__()
 			const Vec3f& vA = objectToWorld.rotation() * entityData.vertexDisplacementSincePrevFrame[triangleIndices.x()];
 			const Vec3f& vB = objectToWorld.rotation() * entityData.vertexDisplacementSincePrevFrame[triangleIndices.y()];
 			const Vec3f& vC = objectToWorld.rotation() * entityData.vertexDisplacementSincePrevFrame[triangleIndices.z()];
-			displacementFromSkinning = objectToWorld.scaleVec() * Vec3f((1 - u - v) * vA + u * vB + v * vC);
+			displacementFromSkinning = Vec3f((1 - u - v) * vA + u * vB + v * vC);
 		}
 
 		absPointVelocity = (displacementFromTransformChange + displacementFromSkinning) /

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ extern "C" __global__ void __closesthit__()`
`193`	`193`	`const Vec3f& vA = objectToWorld.rotation() * entityData.vertexDisplacementSincePrevFrame[triangleIndices.x()];`
`194`	`194`	`const Vec3f& vB = objectToWorld.rotation() * entityData.vertexDisplacementSincePrevFrame[triangleIndices.y()];`
`195`	`195`	`const Vec3f& vC = objectToWorld.rotation() * entityData.vertexDisplacementSincePrevFrame[triangleIndices.z()];`
`196`		`- displacementFromSkinning = objectToWorld.scaleVec() * Vec3f((1 - u - v) * vA + u * vB + v * vC);`
	`196`	`+ displacementFromSkinning = Vec3f((1 - u - v) * vA + u * vB + v * vC);`
`197`	`197`	`}`
`198`	`198`
`199`	`199`	`absPointVelocity = (displacementFromTransformChange + displacementFromSkinning) /`