@@ -37,38 +37,27 @@ paragraph reflows make future maintainers cry.
37
37
Relevant Pages
38
38
--------------
39
39
40
- The relevant modified style guides used by Drake are:
40
+ The subset of the style guides used by Drake are:
41
41
42
- * C++ Style Guide:
43
- [ local preview] ( ./cppguide.html ) |
44
- [ rendered online] ( https://drake.mit.edu/styleguide/cppguide.html )
45
- * Python Style Guide:
46
- [ local preview] ( ./pyguide.html ) \* |
47
- [ rendered online] ( https://drake.mit.edu/styleguide/pyguide.html )
48
-
49
- \* These docs must be generated to preview locally. Please see
50
- < https://drake.mit.edu/documentation_instructions.html > for instructions.
42
+ * C++ Style Guide (aka cppguide)
43
+ * Python Style Guide (aka pyguide)
51
44
52
45
Making New Changes
53
46
------------------
54
47
55
- Branch, update , and PR as you would any other Drake change.
48
+ Branch, edit , and PR to ` styleguide ` as you would any other Drake change.
56
49
57
- Ensure that Drake is updated. See [ Updating Drake] ( #updating-drake ) for more
58
- information.
50
+ Pull requests merged to the ` main ` branch here will not be reflected on
51
+ the https://drake.mit.edu/styleguide website until you also PR to Drake
52
+ to update the git sha it uses for ` styleguide ` .
53
+
54
+ See [ Updating Drake] ( #updating-drake ) for more information.
59
55
60
56
Previewing Changes
61
57
------------------
62
58
63
- Generally, you can preview changes locally without any build. However, if a page
64
- is denoted as needing generation, you can view them locally by running this
65
- script which will indicate necessary prereqs:
66
-
67
- ./preview_site_jekyll.py
68
-
69
- You can alternatively preview them on your own GitHub fork.
70
-
71
- <!-- TODO(eric): Document this workflow. -->
59
+ See https://drake.mit.edu/documentation_instructions.html for how to preview
60
+ your changes.
72
61
73
62
Pulling Upstream Changes
74
63
------------------------
@@ -96,13 +85,12 @@ updates:
96
85
cd styleguide
97
86
98
87
* Add a "drake" remote for the Drake styleguide and make it the default
99
- upstream. Note that for compatibility with Google, we use the branch
100
- ` gh-pages ` as our master:
88
+ upstream.
101
89
102
90
git remote add drake https://github.com/RobotLocomotion/styleguide.git
103
91
git remote set-url --push drake no_push
104
92
git fetch drake
105
- git branch --set-upstream-to drake/gh-pages
93
+ git branch --set-upstream-to drake/main
106
94
107
95
* Add a "google" remote for the Drake styleguide:
108
96
@@ -112,7 +100,7 @@ updates:
112
100
Now that you have a repository and remotes set up, you want to be up-to-date
113
101
with Drake and then pull Google's changes:
114
102
115
- git checkout gh-pages
103
+ git checkout main
116
104
git pull --ff-only
117
105
git checkout -b **NEW_BRANCH_NAME**
118
106
git pull google gh-pages
@@ -139,23 +127,24 @@ Updating Drake
139
127
--------------
140
128
141
129
Whenever a change to ` styleguide ` is made, be sure to submit a PR to ` drake ` to
142
- bump the ` styleguide ` SHA .
130
+ bump the ` styleguide ` git sha .
143
131
144
- If there are no changes to supporting code (e.g. ` cpplint ` ) :
132
+ If there are no changes ` cpplint ` :
145
133
146
- 1 . Submit ` styleguide ` PR, and follow normal review process.
147
- 2 . Submit ` drake ` PR, reference the ` styleguide ` PR, and follow normal review
148
- process.
134
+ 1 . Submit ` styleguide ` PR, and follow normal review process, finally merging
135
+ into the ` main ` branch of this repository.
136
+ 2 . Submit ` drake ` PR to bump the ` styleguide ` git sha, and follow the normal
137
+ review process.
149
138
150
- If there ** are** changes to supporting code :
139
+ If there ** are** changes to ` cpplint ` :
151
140
152
141
1 . Submit the ` styleguide ` PR.
153
142
2 . Submit the ` drake ` PR, reference the ` styleguide ` PR, and mark as
154
143
` do not merge ` .
155
144
3 . Wait until ` drake ` ` *-release ` tests pass.
156
145
4 . Assign review for ` styleguide ` PR. Merge once review is done.
157
146
5 . Update the ` drake ` PR to use the ` styleguide ` merge commit (from
158
- ` gh-pages ` ). Follow normal review process.
147
+ the ` main ` branch; not the PR's git sha ). Follow normal review process.
159
148
160
149
--
161
150
0 commit comments