Skip to content

Refactor project structure, separate concerns, and enhance usage documentation #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 3, 2025

Conversation

x0rw
Copy link
Contributor

@x0rw x0rw commented Apr 30, 2025

Hey 👋 , love this project.

  • Moved internal lock and helper functions out of lib.rs to improve clarity and separation of concerns.
  • Isolated error types into a dedicated errors.rs module for better error handling and modularity.
  • Restructured the project layout by moving integration tests to the/testsdirectory.

Updated README.md with comprehensive usage examples:

  • Environment-based configuration
  • Manual client configuration
  • Service registration and deregistration

i'm working on adding acl feature on my branch after this is pushed, i will open a pr for it too.

Checks

Please check these off before promoting the pull request to non-draft status.

  • All CI checks are green.
  • I have reviewed the proposed changes myself.

Copy link

github-actions bot commented Apr 30, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@x0rw x0rw force-pushed the general-enhancements branch from c32e69b to 6f8e474 Compare April 30, 2025 23:23
@x0rw
Copy link
Contributor Author

x0rw commented Apr 30, 2025

I have read the CLA Document and I hereby sign the CLA

@x0rw x0rw marked this pull request as draft April 30, 2025 23:28
Copy link
Contributor

@kushudai kushudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @x0rw, thank you for this PR!

My main concern here is primarily the breaking changes from types moving to be within modules.

Any thoughts on re-exporting them from lib.rs?

@x0rw
Copy link
Contributor Author

x0rw commented May 1, 2025

Hey @kushudai, Thanks for the review,
About lock and errors exporting i will address them in the next commit--shortly.
I will use 'cargo public-api diff' to ensure there are no breaking changes in this repo.

@x0rw
Copy link
Contributor Author

x0rw commented May 1, 2025

This is the report generated by cargo public-api diff. There are no changes or removals to the public API now.
Additionally, quick_error!() is unmaintained(i checked, the last update was 4 years ago) and no longer considered ergonomic, lacking proper visibility control. It would be beneficial to migrate to thiserror for long-term maintainability.

Removed items from the public API
=================================
(none)

Changed items in the public API
===============================
(none)

Added items to the public API
=============================
+impl rs_consul::Consul

@kushudai
Copy link
Contributor

kushudai commented May 2, 2025

This is the report generated by cargo public-api diff. There are no changes or removals to the public API now. Additionally, quick_error!() is unmaintained(i checked, the last update was 4 years ago) and no longer considered ergonomic, lacking proper visibility control. It would be beneficial to migrate to thiserror for long-term maintainability.

Removed items from the public API
=================================
(none)

Changed items in the public API
===============================
(none)

Added items to the public API
=============================
+impl rs_consul::Consul

Thank you, you're right. This crate has not seen as much love as I would like it to.
You're welcome to fix that in this PR but I don't want ask more of you or throw scope creep on this change.

I'm happy to pick that up separately.

@x0rw
Copy link
Contributor Author

x0rw commented May 2, 2025

It's not an issue at all, I'd be happy to look into that.

Copy link
Contributor

@kushudai kushudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to mark this as PR ready when you feel comfortable about merging this.
Again, thank you for the work!

Co-authored-by: Kushagra Udai <112903599+kushudai@users.noreply.github.com>
@x0rw
Copy link
Contributor Author

x0rw commented May 3, 2025

It's ready for merging now, i will work on a feature next week.

@x0rw x0rw marked this pull request as ready for review May 3, 2025 19:58
@kushudai kushudai merged commit 49f29b5 into Roblox:main May 3, 2025
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants