-
Notifications
You must be signed in to change notification settings - Fork 31
Refactor project structure, separate concerns, and enhance usage documentation #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Usage examples(Environment config, manual config, registring and deregistring service)
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
c32e69b
to
6f8e474
Compare
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @x0rw, thank you for this PR!
My main concern here is primarily the breaking changes from types moving to be within modules.
Any thoughts on re-exporting them from lib.rs?
Hey @kushudai, Thanks for the review, |
This is the report generated by
|
Thank you, you're right. This crate has not seen as much love as I would like it to. I'm happy to pick that up separately. |
It's not an issue at all, I'd be happy to look into that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to mark this as PR ready when you feel comfortable about merging this.
Again, thank you for the work!
Co-authored-by: Kushagra Udai <112903599+kushudai@users.noreply.github.com>
It's ready for merging now, i will work on a feature next week. |
Hey 👋 , love this project.
lib.rs
to improve clarity and separation of concerns.errors.rs
module for better error handling and modularity./tests
directory.Updated README.md with comprehensive usage examples:
i'm working on adding acl feature on my branch after this is pushed, i will open a pr for it too.
Checks
Please check these off before promoting the pull request to non-draft status.