Fix #150

DivadNojnarg · DivadNojnarg · commit 75a34aa8836f · 2021-09-15T22:30:28.000+02:00
diff --git a/NEWS.md b/NEWS.md
@@ -5,6 +5,9 @@ Shiny 1.7.0. Thanks @wch.
 ## Minor change
 - Internal change regarding the `{waiter}` package but no user impact. Thanks @JohnCoene. 
 
+## Bug fix
+- Fix #150: Warning when using controlbarMenu. 
+
 # shinydashboardPlus 2.0.2
 
 - Simple patch to fix wrong .Rbuildignore [rule](https://github.com/DivadNojnarg/outstanding-shiny-ui/issues/52).
diff --git a/R/dashboardControlbar.R b/R/dashboardControlbar.R
@@ -223,8 +223,7 @@ controlbarMenu <- function(..., id = NULL, selected = NULL) {
     ...,
     id = id,
     selected = selected,
-    type = "tabs",
-    position = NULL
+    type = "tabs"
   )
   
   # remove parent div causing CSS margin issues
diff --git a/docs/news/index.html b/docs/news/index.html

Original file line number	Diff line number	Diff line change
`@@ -223,8 +223,7 @@ controlbarMenu <- function(..., id = NULL, selected = NULL) {`
`223`	`223`	`...,`
`224`	`224`	`id = id,`
`225`	`225`	`selected = selected,`
`226`		`- type = "tabs",`
`227`		`- position = NULL`
	`226`	`+ type = "tabs"`
`228`	`227`	`)`
`229`	`228`
`230`	`229`	`# remove parent div causing CSS margin issues`