Fix FileHandler's potential crash on writing
#5675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 Snapshot Test76 modified, 799 unchanged
🛸 Powered by Emerge Tools |
rickvdl
approved these changes
Oct 17, 2025
tonidero
approved these changes
Oct 17, 2025
JayShortway
approved these changes
Oct 17, 2025
| func append(line: String) throws { | ||
| RCTestAssertNotMainThread() | ||
|
|
||
| self.fileHandle.seekToEndOfFile() |
There was a problem hiding this comment.
There's also seekToEnd(), which is maybe newer? I genuinely don't know haha.
Suggested change
| self.fileHandle.seekToEndOfFile() | |
| self.fileHandle.seekToEnd() |
There was a problem hiding this comment.
Oh, great catch! Thank you! Done in f16e0b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5667
Motivation
The
FileHandlerappend(line:)method was using an older API that would produce a crash when writing to the file fails (e.g. not enough disk space available) instead of throwing an error. See https://developer.apple.com/documentation/foundation/filehandle/write(_:).Description
This PR changes it to use the newer
FileHandle'swrite(contentsOf:)API