-
Notifications
You must be signed in to change notification settings - Fork 392
Update Xcode 16.0 to 16.4 in tests because of CircleCI's deprecation later this year #5668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Xcode 16.0 to 16.4 in tests because of CircleCI's deprecation later this year #5668
Conversation
@RCGitBot please test |
1 build increased size, 3 builds decreased size
RevenueCat 1.0 (1)
|
Item | Install Size Change |
---|---|
DYLD.String Table | ⬆️ 1.9 MB |
DYLD.String Table | ⬆️ 149.1 kB |
Code Signature | ⬆️ 122.9 kB |
DYLD.String Table | ⬆️ 60.7 kB |
DYLD.String Table | ⬆️ 30.7 kB |
RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 1.2 MB (-2.66%)
Total download size change: ⬇️ 117.0 kB (-0.97%)
Largest size changes
Item | Install Size Change |
---|---|
DYLD.String Table | ⬇️ -497.4 kB |
Code Signature | ⬇️ -29.5 kB |
RevenueCat.OfferingsFactory.OfferingsFactory | ⬇️ -18.6 kB |
RevenueCat.CustomerInfoManager.CustomerInfoManager | ⬆️ 14.4 kB |
RevenueCat.AttributionDataMigrator.AttributionDataMigrator | ⬆️ 11.3 kB |
RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 1.2 MB (-2.66%)
Total download size change: ⬇️ 117.0 kB (-0.97%)
Largest size changes
Item | Install Size Change |
---|---|
DYLD.String Table | ⬇️ -497.4 kB |
Code Signature | ⬇️ -29.5 kB |
RevenueCat.OfferingsFactory.OfferingsFactory | ⬇️ -18.6 kB |
RevenueCat.CustomerInfoManager.CustomerInfoManager | ⬆️ 14.4 kB |
RevenueCat.AttributionDataMigrator.AttributionDataMigrator | ⬆️ 11.3 kB |
RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester.mac-native
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 1.0 MB (-2.64%)
Total download size change: ⬇️ 111.6 kB (-1.06%)
Largest size changes
Item | Install Size Change |
---|---|
DYLD.String Table | ⬇️ -410.2 kB |
Code Signature | ⬇️ -25.6 kB |
RevenueCat.OfferingsFactory.OfferingsFactory | ⬇️ -18.6 kB |
RevenueCat.CustomerInfoManager.CustomerInfoManager | ⬆️ 14.4 kB |
RevenueCat.AttributionDataMigrator.AttributionDataMigrator | ⬆️ 11.3 kB |
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
📸 Snapshot Test17 modified, 858 unchanged
🛸 Powered by Emerge Tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this!
I think you need to update the device's OS versions for the tests to use a version that is preinstalled with the Xcode version. Here you can see the installed software in the Xcode 16.4 machines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think changes look good! Test seem to be failing, seemingly because of some new checks performed with this version of xcode that we should fix
@RCGitBot please test |
@RCGitBot please test |
@RCGitBot please test |
956c348
to
53c1f33
Compare
@RCGitBot please test |
53c1f33
to
def21cd
Compare
@RCGitBot please test |
CircleCI announced that they're deprecating several Xcode image versions later this year (early November).
I've compiled a list of Xcode versions and device version we use for testing.
According to CircleCI's post this should only affect our use of Xcode 16.0. Which we should update to use 16.4 instead. With this PR I'm updating all our uses of Xcode 16.0 to use 16.4 instead.
After these updates the list looks like this