-
Notifications
You must be signed in to change notification settings - Fork 392
DENG-1449 - Move large object cacheing off of user defaults to file storage #5652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JZDesign
wants to merge
9
commits into
main
Choose a base branch
from
jzdesign/deng-1449/tvos.userdefaults.crash
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 Snapshot Test9 modified, 866 unchanged
🛸 Powered by Emerge Tools |
…github.com//RevenueCat/purchases-ios into jzdesign/deng-1449/tvos.userdefaults.crash
rickvdl
reviewed
Oct 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, code itself looks good to me, but I don't think I have enough context yet to know how this affects the rest of the SDK, so I'll leave approval for someone who does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have crashes in tvOS due to overloading the user defaults.
Description
Converts the storage for all Codable objects from UserDefaults to the cache directory in the file system
Checklist
purchases-android
and hybrids