Skip to content

userProfileElements property on APCPermissionsManager is not a permission type #118

@ghost

Description

APCPermissionsManager is effectively a global variable holding a representation of the configuration of permissions, returning the state of permissions, and requesting those permissions when necessary. While userInfoItemTypes behave like permissions, they are not actually permissions.

APCPermissionsManager has the following property in the header file:

@property (copy, nonatomic) NSArray *userInfoItemTypes;

The userInfoItemTypes are used to configure view controller elements by prepareContent() methods in APCProfileViewController, APCSignUpMedicalInfoViewController, and APCSignUpGeneralInfoViewController.

A future review of this architecture might for example, add a userInfoConfiguration object to resolve this issue. Discussion in #117 recommended that neither APCPermissionsManager or APCOnboardingManager be the home for the array of userInfoItemTypes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions