feat: add react-x/no-nested-lazy-component-declarations rule, closes #1048 (#1052)

Author: Rel1cx

apps/website/content/docs/rules/meta.json

@@ -34,6 +34,7 @@
     "no-missing-key",
     "no-misused-capture-owner-stack",
     "no-nested-component-definitions",
+    "no-nested-lazy-component-declarations",
     "no-prop-types",
     "no-redundant-should-component-update",
     "no-set-state-in-component-did-mount",

apps/website/content/docs/rules/overview.mdx

@@ -57,6 +57,7 @@ Linter rules can have false positives, false negatives, and some rules are depen
 | [`no-missing-key`](./no-missing-key)                                                 | 2️⃣  |          | Disallow missing `key` on items in list rendering                                                    |           |
 | [`no-misused-capture-owner-stack`](./no-misused-capture-owner-stack)                 | 0️⃣  |   `🧪`   | Prevents incorrect usage of `captureOwnerStack`                                                      |           |
 | [`no-nested-component-definitions`](./no-nested-component-definitions)               | 2️⃣  |          | Disallow nesting component definitions inside other components                                       |           |
+| [`no-nested-lazy-component-declarations`](./no-nested-lazy-component-declarations)   | 2️⃣  |          | Disallow nesting lazy component declarations inside other components                                 |           |
 | [`no-prop-types`](./no-prop-types)                                                   | 2️⃣  |          | Disallow `propTypes` in favor of TypeScript or another type-checking solution                        |           |
 | [`no-redundant-should-component-update`](./no-redundant-should-component-update)     | 2️⃣  |          | Disallow `shouldComponentUpdate` when extending `React.PureComponent`                                |           |
 | [`no-set-state-in-component-did-mount`](./no-set-state-in-component-did-mount)       | 1️⃣  |          | Disallow calling `this.setState` in `componentDidMount` outside of functions, such as callbacks      |           |

packages/core/docs/README.md

@@ -60,6 +60,8 @@
 - [isForwardRef](variables/isForwardRef.md)
 - [isForwardRefCall](variables/isForwardRefCall.md)
 - [isInversePhase](variables/isInversePhase.md)
+- [isLazy](variables/isLazy.md)
+- [isLazyCall](variables/isLazyCall.md)
 - [isMemo](variables/isMemo.md)
 - [isMemoCall](variables/isMemoCall.md)
 - [isUseActionStateCall](variables/isUseActionStateCall.md)

packages/core/docs/variables/isLazy.md

@@ -0,0 +1,9 @@
+[**@eslint-react/core**](../README.md)
+
+***
+
+[@eslint-react/core](../README.md) / isLazy
+
+# Variable: isLazy
+
+> `const` **isLazy**: `ReturnType`

packages/core/docs/variables/isLazyCall.md

@@ -0,0 +1,9 @@
+[**@eslint-react/core**](../README.md)
+
+***
+
+[@eslint-react/core](../README.md) / isLazyCall
+
+# Variable: isLazyCall
+
+> `const` **isLazyCall**: `ReturnType`

packages/core/src/component/component-definition.ts

@@ -42,7 +42,7 @@ export function isValidComponentDefinition(context: RuleContext, node: AST.TSEST
   if (hint & ComponentDetectionHint.SkipArrayMapArgument && AST.isArrayMapCall(node.parent)) {
     return false;
   }
-  const boundaryNode = AST.findParentNode(
+  const significantParent = AST.findParentNode(
     node,
     AST.isOneOf([
       T.JSXExpressionContainer,
@@ -52,5 +52,5 @@ export function isValidComponentDefinition(context: RuleContext, node: AST.TSEST
       T.ClassBody,
     ]),
   );
-  return boundaryNode == null || boundaryNode.type !== T.JSXExpressionContainer;
+  return significantParent == null || significantParent.type !== T.JSXExpressionContainer;
 }

packages/core/src/utils/is-react-api.ts

@@ -32,6 +32,7 @@ export const isCreateElement = isReactAPI("createElement");
 export const isCreateRef = isReactAPI("createRef");
 export const isForwardRef = isReactAPI("forwardRef");
 export const isMemo = isReactAPI("memo");
+export const isLazy = isReactAPI("lazy");
 
 export const isCaptureOwnerStackCall = isReactAPICall("captureOwnerStack");
 export const isChildrenCountCall = isReactAPICall("Children", "count");
@@ -45,3 +46,4 @@ export const isCreateElementCall = isReactAPICall("createElement");
 export const isCreateRefCall = isReactAPICall("createRef");
 export const isForwardRefCall = isReactAPICall("forwardRef");
 export const isMemoCall = isReactAPICall("memo");
+export const isLazyCall = isReactAPICall("lazy");

packages/plugins/eslint-plugin-react-debug/src/rules/class-component.ts

@@ -34,8 +34,8 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
   const { ctx, listeners } = ER.useComponentCollectorLegacy();
   return {
     ...listeners,
-    "Program:exit"(node) {
-      const components = ctx.getAllComponents(node);
+    "Program:exit"(program) {
+      const components = ctx.getAllComponents(program);
       for (const { name = "anonymous", node: component } of components.values()) {
         context.report({
           messageId: "classComponent",

packages/plugins/eslint-plugin-react-debug/src/rules/function-component.ts

@@ -42,8 +42,8 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
   );
   return {
     ...listeners,
-    "Program:exit"(node) {
-      const components = ctx.getAllComponents(node);
+    "Program:exit"(program) {
+      const components = ctx.getAllComponents(program);
       for (const { name = "anonymous", node, displayName, flag, hookCalls } of components.values()) {
         context.report({
           messageId: "functionComponent",

packages/plugins/eslint-plugin-react-debug/src/rules/hook.ts

@@ -35,8 +35,8 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
 
   return {
     ...listeners,
-    "Program:exit"(node) {
-      const allHooks = ctx.getAllHooks(node);
+    "Program:exit"(program) {
+      const allHooks = ctx.getAllHooks(program);
 
       for (const { name, node, hookCalls } of allHooks.values()) {
         context.report({