release: 0.9.8-beta.2

Rel1cx · Rel1cx · commit 1273767cba95 · 2023-12-19T09:20:20.000+08:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,22 @@
+## v0.9.8-beta.2 (Tue Dec 19 2023)
+
+### Release Notes
+
+Optimize `recommended` and `recommended-legacy` presets.
+
+---
+
+🚀 Enhancement
+
+- `@eslint-react/eslint-plugin`
+  - Optimize `recommended` and `recommended-legacy` presets.
+
+#### Authors: 1
+
+- Eva1ent ([@Rel1cx](https://github.com/Rel1cx))
+
+---
+
 ## v0.9.8-beta.1 (Tue Dec 19 2023)
 
 ### Release Notes
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-0.9.8-beta.1
+0.9.8-beta.2
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/monorepo",
-  "version": "0.9.8-beta.1",
+  "version": "0.9.8-beta.2",
   "description": "ESLint React's monorepo. More than 50 ESLint rules to catch common mistakes and improve your React code. Built (mostly) from scratch.",
   "keywords": [
     "eslint",
@@ -70,7 +70,7 @@
     "@typescript-eslint/rule-tester": "6.15.0",
     "@vitest/ui": "1.0.4",
     "bun": "1.0.18",
-    "bun-types": "1.0.18-1",
+    "bun-types": "1.0.18-canary.20231218T214637",
     "cspell": "8.1.3",
     "dedent": "1.5.1",
     "dprint": "0.44.0",
diff --git a/packages/ast/package.json b/packages/ast/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/ast",
-  "version": "0.9.8-beta.1",
+  "version": "0.9.8-beta.2",
   "description": "ESLint React's TSESTree AST primitive utility module.",
   "homepage": "https://github.com/rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/core",
-  "version": "0.9.8-beta.1",
+  "version": "0.9.8-beta.2",
   "description": "ESLint React's ESLint utility module for static analysis of React core API and Patterns.",
   "homepage": "https://github.com/rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/core/src/api/api.ts b/packages/core/src/api/api.ts
@@ -3,7 +3,7 @@ import type { TSESTree } from "@typescript-eslint/types";
 
 import { isReactAPI, isReactAPICall } from "../internal";
 
-// workaround for @typescript-eslint/utils's TS2742 error.
+// Workaround for @typescript-eslint/utils's TS2742 error.
 type A = (node: TSESTree.Identifier | TSESTree.MemberExpression, context: RuleContext) => boolean;
 type B = (node: TSESTree.MemberExpression, context: RuleContext, pragma?: string) => boolean;
 type X = (node: TSESTree.CallExpression, context: RuleContext) => boolean;
diff --git a/packages/eslint-plugin-debug/package.json b/packages/eslint-plugin-debug/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/eslint-plugin-debug",
-  "version": "0.9.8-beta.1",
+  "version": "0.9.8-beta.2",
   "description": "ESLint React's ESLint plugin for debugging related rules.",
   "homepage": "https://github.com/rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/eslint-plugin-debug/src/index.ts b/packages/eslint-plugin-debug/src/index.ts
@@ -1,4 +1,4 @@
-// workaround for @typescript-eslint/utils's TS2742 error.
+// Workaround for @typescript-eslint/utils's TS2742 error.
 import type { ESLintUtils } from "@typescript-eslint/utils";
 
 import { name, version } from "../package.json";
diff --git a/packages/eslint-plugin-jsx/package.json b/packages/eslint-plugin-jsx/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/eslint-plugin-jsx",
-  "version": "0.9.8-beta.1",
+  "version": "0.9.8-beta.2",
   "description": "ESLint React's ESLint plugin for JSX related rules.",
   "homepage": "https://github.com/rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/eslint-plugin-jsx/src/index.ts b/packages/eslint-plugin-jsx/src/index.ts
@@ -1,4 +1,4 @@
-// workaround for @typescript-eslint/utils's TS2742 error.
+// Workaround for @typescript-eslint/utils's TS2742 error.
 import type { ESLintUtils } from "@typescript-eslint/utils";
 
 import { name, version } from "../package.json";
diff --git a/packages/eslint-plugin-jsx/src/rules/no-complicated-conditional-rendering.md b/packages/eslint-plugin-jsx/src/rules/no-complicated-conditional-rendering.md
@@ -2,7 +2,7 @@
 
 ## Rule category
 
-Complexity.
+Style.
 
 ## What it does
 
diff --git a/packages/eslint-plugin-naming-convention/package.json b/packages/eslint-plugin-naming-convention/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/eslint-plugin-naming-convention",
-  "version": "0.9.8-beta.1",
+  "version": "0.9.8-beta.2",
   "description": "ESLint React's ESLint plugin for naming convention related rules.",
   "homepage": "https://github.com/rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/eslint-plugin-naming-convention/src/index.ts b/packages/eslint-plugin-naming-convention/src/index.ts
@@ -1,4 +1,4 @@
-// workaround for @typescript-eslint/utils's TS2742 error.
+// Workaround for @typescript-eslint/utils's TS2742 error.
 import type { ESLintUtils } from "@typescript-eslint/utils";
 
 import { name, version } from "../package.json";
diff --git a/packages/eslint-plugin-react-hooks/package.json b/packages/eslint-plugin-react-hooks/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/eslint-plugin-react-hooks",
-  "version": "0.9.8-beta.1",
+  "version": "0.9.8-beta.2",
   "description": "ESLint React's ESLint plugin for React Hooks related rules.",
   "homepage": "https://github.com/rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/eslint-plugin-react-hooks/src/index.ts b/packages/eslint-plugin-react-hooks/src/index.ts
@@ -1,4 +1,4 @@
-// workaround for @typescript-eslint/utils's TS2742 error.
+// Workaround for @typescript-eslint/utils's TS2742 error.
 import type { ESLintUtils } from "@typescript-eslint/utils";
 
 import { name, version } from "../package.json";
diff --git a/packages/eslint-plugin-react/package.json b/packages/eslint-plugin-react/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/eslint-plugin-react",
-  "version": "0.9.8-beta.1",
+  "version": "0.9.8-beta.2",
   "description": "ESLint React's ESLint plugin for React related rules.",
   "homepage": "https://github.com/rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/eslint-plugin-react/src/rules/no-unstable-nested-components.md b/packages/eslint-plugin-react/src/rules/no-unstable-nested-components.md
@@ -10,7 +10,7 @@ Prevents nesting component definitions inside other components.
 
 ## Why is this bad?
 
-Nesting component definitions inside other components is a common mistake that can be extremely slow and cause issues and bugs. Instead, define every component at the top level.
+Nesting component definitions inside other components is a common mistake that can be extremely slow and cause issues and bugs, and the state of components defined during rendering will not be preserved by React. Instead, define every component at the top level.
 
 ## Examples
 
diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/eslint-plugin",
-  "version": "0.9.8-beta.1",
+  "version": "0.9.8-beta.2",
   "description": "ESLint React's main ESLint plugin. More than 50 ESLint rules to catch common mistakes and improve your React code. Built (mostly) from scratch.",
   "keywords": [
     "eslint",
diff --git a/packages/eslint-plugin/src/index.ts b/packages/eslint-plugin/src/index.ts
@@ -6,7 +6,7 @@ import * as hooks from "@eslint-react/eslint-plugin-react-hooks";
 import { Helper } from "@eslint-react/tools";
 import type { RulePreset } from "@eslint-react/types";
 import tsParser from "@typescript-eslint/parser";
-// workaround for @typescript-eslint/utils's TS2742 error.
+// Workaround for @typescript-eslint/utils's TS2742 error.
 import type { ESLintUtils } from "@typescript-eslint/utils";
 
 import { name, version } from "../package.json";
@@ -82,31 +82,37 @@ const rulePreset = {
 
 const recommendedPreset = {
   "jsx/no-array-index-key": "warn",
+  // Not enabled because it rarely happens.
   // "jsx/no-comment-textnodes": "warn",
+  // Not enabled because it's style related.
   // "jsx/no-complicated-conditional-rendering": "warn",
   "jsx/no-duplicate-key": "error",
+  // Not enabled because it requires type information.
   // "jsx/no-leaked-conditional-rendering": "warn",
   "jsx/no-missing-key": "error",
   "jsx/no-spreading-key": "warn",
   "jsx/no-useless-fragment": "warn",
   "jsx/prefer-shorthand-boolean": "warn",
   "jsx/prefer-shorthand-fragment": "warn",
 
-  "naming-convention/component-name": "warn",
+  // Not enabled because naming convention rules are dependent on the project.
+  // "naming-convention/component-name": "warn",
   // "naming-convention/filename": "warn",
   // "naming-convention/filename-extension": "warn",
-  "naming-convention/use-state": "warn",
+  // "naming-convention/use-state": "warn",
 
-  "react/ensure-forward-ref-using-ref": "error",
+  "react/ensure-forward-ref-using-ref": "warn",
   "react/no-children-count": "warn",
   "react/no-children-for-each": "warn",
   "react/no-children-in-void-dom-elements": "warn",
   "react/no-children-map": "warn",
   "react/no-children-only": "warn",
   "react/no-children-prop": "warn",
   "react/no-children-to-array": "warn",
+  // Not enabled because it depends on the project.
   // "react/no-class-component": "warn",
-  "react/no-clone-element": "warn",
+  // Not enabled because it's legacy but still widely used.
+  // "react/no-clone-element": "warn",
   "react/no-component-will-mount": "error",
   "react/no-component-will-receive-props": "error",
   "react/no-component-will-update": "error",
@@ -117,10 +123,11 @@ const recommendedPreset = {
   "react/no-direct-mutation-state": "error",
   "react/no-find-dom-node": "error",
   "react/no-missing-button-type": "warn",
+  // Not enabled because it's only useful when using devtools.
   // "react/no-missing-component-display-name": "warn",
   "react/no-missing-iframe-sandbox": "warn",
   "react/no-namespace": "error",
-  "react/no-redundant-should-component-update": "warn",
+  "react/no-redundant-should-component-update": "error",
   "react/no-render-return-value": "error",
   "react/no-script-url": "warn",
   "react/no-set-state-in-component-did-mount": "warn",
@@ -132,11 +139,13 @@ const recommendedPreset = {
   "react/no-unsafe-component-will-update": "warn",
   "react/no-unsafe-iframe-sandbox": "warn",
   "react/no-unsafe-target-blank": "warn",
-  "react/no-unstable-default-props": "warn",
+  "react/no-unstable-default-props": "error",
   "react/no-unstable-nested-components": "warn",
-  "react/prefer-destructuring-assignment": "warn",
+  // Not enabled because it's style related.
+  // "react/prefer-destructuring-assignment": "warn",
 
-  "react-hooks/ensure-custom-hooks-using-other-hooks": "warn",
+  // Not enabled because it triggers prematurely before the code is fully written.
+  // "react-hooks/ensure-custom-hooks-using-other-hooks": "warn",
   // "react-hooks/ensure-use-callback-has-non-empty-deps": "warn",
   // "react-hooks/ensure-use-memo-has-non-empty-deps": "warn",
   // "react-hooks/prefer-use-state-lazy-initialization": "warn",
diff --git a/packages/eslint-utils/package.json b/packages/eslint-utils/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/eslint-utils",
-  "version": "0.9.8-beta.1",
+  "version": "0.9.8-beta.2",
   "description": "ESLint React's utilities.",
   "homepage": "https://github.com/rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/jsx/package.json b/packages/jsx/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/jsx",
-  "version": "0.9.8-beta.1",
+  "version": "0.9.8-beta.2",
   "description": "ESLint React's TSESTree AST utility module for static analysis of JSX.",
   "homepage": "https://github.com/rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/jsx/src/element/api.ts b/packages/jsx/src/element/api.ts
@@ -4,7 +4,7 @@ import type { TSESTree } from "@typescript-eslint/types";
 
 import { isFromPragma } from "../pragma";
 
-// workaround for @typescript-eslint/utils's TS2742 error.
+// Workaround for @typescript-eslint/utils's TS2742 error.
 type _ = (node: TSESTree.Identifier | TSESTree.MemberExpression, context: RuleContext) => boolean;
 
 export const isCreateElement: _ = isFromPragma("createElement");
diff --git a/packages/shared/package.json b/packages/shared/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/shared",
-  "version": "0.9.8-beta.1",
+  "version": "0.9.8-beta.2",
   "description": "ESLint React's shared data and constants.",
   "homepage": "https://github.com/rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/tools/docs/modules/Record.md b/packages/tools/docs/modules/Record.md
@@ -19,6 +19,7 @@
 - [filterMap](Record.md#filtermap)
 - [fromEntries](Record.md#fromentries)
 - [fromIterable](Record.md#fromiterable)
+- [fromIterableBy](Record.md#fromiterableby)
 - [fromIterableWith](Record.md#fromiterablewith)
 - [get](Record.md#get)
 - [getEquivalence](Record.md#getequivalence)
@@ -1474,6 +1475,54 @@ Creates a new record from an iterable collection of key/value pairs.
 
 ___
 
+### fromIterableBy
+
+▸ **fromIterableBy**\<`A`\>(`items`, `f`): `Record`\<`string`, `A`\>
+
+Creates a new record from an iterable, utilizing the provided function to determine the key for each element.
+
+#### Type parameters
+
+| Name |
+| :------ |
+| `A` |
+
+#### Parameters
+
+| Name | Type | Description |
+| :------ | :------ | :------ |
+| `items` | `Iterable`\<`A`\> | An iterable containing elements. |
+| `f` | (`a`: `A`) => `string` | A function that extracts the key for each element. |
+
+#### Returns
+
+`Record`\<`string`, `A`\>
+
+**`Example`**
+
+```ts
+import { fromIterableBy } from "effect/ReadonlyRecord"
+
+const users = [
+  { id: "2", name: "name2" },
+  { id: "1", name: "name1" }
+]
+
+assert.deepStrictEqual(
+  fromIterableBy(users, user => user.id),
+  {
+    "2": { id: "2", name: "name2" },
+    "1": { id: "1", name: "name1" }
+  }
+)
+```
+
+**`Since`**
+
+2.0.0
+
+___
+
 ### fromIterableWith
 
 ▸ **fromIterableWith**\<`A`, `B`\>(`f`): (`self`: `Iterable`\<`A`\>) => `Record`\<`string`, `B`\>
diff --git a/packages/tools/package.json b/packages/tools/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/tools",
-  "version": "0.9.8-beta.1",
+  "version": "0.9.8-beta.2",
   "description": "ESLint React's std library and primitives.",
   "homepage": "https://github.com/rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/types/package.json b/packages/types/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eslint-react/types",
-  "version": "0.9.8-beta.1",
+  "version": "0.9.8-beta.2",
   "description": "ESLint React's type definitions.",
   "homepage": "https://github.com/rel1cx/eslint-react",
   "bugs": {
diff --git a/packages/types/src/rule-category.ts b/packages/types/src/rule-category.ts
@@ -1,5 +1,5 @@
 export type RuleCategory =
-  | "complexity" // Rules to indicate code that does something simple but in a complex way or help prevent complex code
+  | "complexity" // Rules to indicate code that does something simple but in a complex way
   | "correctness" // Rules to indicate code that is outright wrong or useless
   | "debug" // Rules to help debug code (e.g. debug-function-component)
   | "deprecated" // Rules that already deprecated and should not be used
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/website/.eslintrc.cjs b/website/.eslintrc.cjs

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@eslint-react/ast",`
`3`		`- "version": "0.9.8-beta.1",`
	`3`	`+ "version": "0.9.8-beta.2",`
`4`	`4`	`"description": "ESLint React's TSESTree AST primitive utility module.",`
`5`	`5`	`"homepage": "https://github.com/rel1cx/eslint-react",`
`6`	`6`	`"bugs": {`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@eslint-react/core",`
`3`		`- "version": "0.9.8-beta.1",`
	`3`	`+ "version": "0.9.8-beta.2",`
`4`	`4`	`"description": "ESLint React's ESLint utility module for static analysis of React core API and Patterns.",`
`5`	`5`	`"homepage": "https://github.com/rel1cx/eslint-react",`
`6`	`6`	`"bugs": {`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@eslint-react/eslint-plugin-debug",`
`3`		`- "version": "0.9.8-beta.1",`
	`3`	`+ "version": "0.9.8-beta.2",`
`4`	`4`	`"description": "ESLint React's ESLint plugin for debugging related rules.",`
`5`	`5`	`"homepage": "https://github.com/rel1cx/eslint-react",`
`6`	`6`	`"bugs": {`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// workaround for @typescript-eslint/utils's TS2742 error.`
	`1`	`+// Workaround for @typescript-eslint/utils's TS2742 error.`
`2`	`2`	`import type { ESLintUtils } from "@typescript-eslint/utils";`
`3`	`3`
`4`	`4`	`import { name, version } from "../package.json";`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@eslint-react/eslint-plugin-jsx",`
`3`		`- "version": "0.9.8-beta.1",`
	`3`	`+ "version": "0.9.8-beta.2",`
`4`	`4`	`"description": "ESLint React's ESLint plugin for JSX related rules.",`
`5`	`5`	`"homepage": "https://github.com/rel1cx/eslint-react",`
`6`	`6`	`"bugs": {`