Skip to content

Commit e0370ca

Browse files
xORBDB6/xUNBDB6: fix a constant
The commits listed below updated xORBDB6/xUNBDB6 with the aim of improving numerical stability by avoiding the use of squared values. With the exception of SORBDB6 these commits did not properly up a magic constant called `ALPHA` in the code. SORBDB6 was initially updated correctly before commit a015b21 inserted an incorrect value again. The incorrect magic constant may lead to early returns with only partially orthogonalized output vectors. Relevant commits: * 54b3964 * 6479e0f * 94419e8
1 parent ada20a0 commit e0370ca

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

SRC/cunbdb6.f

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ SUBROUTINE CUNBDB6( M1, M2, N, X1, INCX1, X2, INCX2, Q1, LDQ1, Q2,
174174
*
175175
* .. Parameters ..
176176
REAL ALPHA, REALONE, REALZERO
177-
PARAMETER ( ALPHA = 0.01E0, REALONE = 1.0E0,
177+
PARAMETER ( ALPHA = 0.1E0, REALONE = 1.0E0,
178178
$ REALZERO = 0.0E0 )
179179
COMPLEX NEGONE, ONE, ZERO
180180
PARAMETER ( NEGONE = (-1.0E0,0.0E0), ONE = (1.0E0,0.0E0),

SRC/dorbdb6.f

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ SUBROUTINE DORBDB6( M1, M2, N, X1, INCX1, X2, INCX2, Q1, LDQ1, Q2,
174174
*
175175
* .. Parameters ..
176176
DOUBLE PRECISION ALPHA, REALONE, REALZERO
177-
PARAMETER ( ALPHA = 0.01D0, REALONE = 1.0D0,
177+
PARAMETER ( ALPHA = 0.1D0, REALONE = 1.0D0,
178178
$ REALZERO = 0.0D0 )
179179
DOUBLE PRECISION NEGONE, ONE, ZERO
180180
PARAMETER ( NEGONE = -1.0D0, ONE = 1.0D0, ZERO = 0.0D0 )

SRC/sorbdb6.f

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ SUBROUTINE SORBDB6( M1, M2, N, X1, INCX1, X2, INCX2, Q1, LDQ1, Q2,
174174
*
175175
* .. Parameters ..
176176
REAL ALPHA, REALONE, REALZERO
177-
PARAMETER ( ALPHA = 0.01E0, REALONE = 1.0E0,
177+
PARAMETER ( ALPHA = 0.1E0, REALONE = 1.0E0,
178178
$ REALZERO = 0.0E0 )
179179
REAL NEGONE, ONE, ZERO
180180
PARAMETER ( NEGONE = -1.0E0, ONE = 1.0E0, ZERO = 0.0E0 )

SRC/zunbdb6.f

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ SUBROUTINE ZUNBDB6( M1, M2, N, X1, INCX1, X2, INCX2, Q1, LDQ1, Q2,
174174
*
175175
* .. Parameters ..
176176
DOUBLE PRECISION ALPHA, REALONE, REALZERO
177-
PARAMETER ( ALPHA = 0.01D0, REALONE = 1.0D0,
177+
PARAMETER ( ALPHA = 0.1D0, REALONE = 1.0D0,
178178
$ REALZERO = 0.0D0 )
179179
COMPLEX*16 NEGONE, ONE, ZERO
180180
PARAMETER ( NEGONE = (-1.0D0,0.0D0), ONE = (1.0D0,0.0D0),

0 commit comments

Comments
 (0)