Skip to content

Commit c3eaab3

Browse files
committed
corrected comments in TESTING/LIN/dchkqp3rk.f for KMAX loop
1 parent 667f08c commit c3eaab3

File tree

1 file changed

+23
-24
lines changed

1 file changed

+23
-24
lines changed

TESTING/LIN/dchkqp3rk.f

Lines changed: 23 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -216,11 +216,11 @@ SUBROUTINE DCHKQP3RK( DOTYPE, NM, MVAL, NN, NVAL, NNS, NSVAL,
216216
INTEGER I, IHIGH, ILOW, IM, IMAT, IN, INC_ZERO,
217217
$ INB, IND_OFFSET_GEN,
218218
$ IND_IN, IND_OUT, INS, INFO,
219-
$ ISTEP, J, J_INC, J_FIRST_NZ, JB_ZERO, K,
219+
$ ISTEP, J, J_INC, J_FIRST_NZ, JB_ZERO,
220220
$ KFACT, KL, KMAX, KU, LDA, LW, LWORK,
221221
$ LWORK_DORMQR, M, MINMN, MINMNB_GEN, MODE, N,
222222
$ NB, NB_ZERO, NERRS, NFAIL, NB_GEN, NRHS,
223-
$ NRUN, NX, SHIFT, T
223+
$ NRUN, NX, T
224224
DOUBLE PRECISION ANORM, CNDNUM, EPS, ABSTOL, RELTOL,
225225
$ DTEMP, MAXC2NRMK, RELMAXC2NRMK,
226226
$ TEST1, TEST2
@@ -681,7 +681,6 @@ SUBROUTINE DCHKQP3RK( DOTYPE, NM, MVAL, NN, NVAL, NNS, NSVAL,
681681
*
682682
DO INB = 1, NNB
683683
*
684-
*
685684
* Do for each pair of values (NB,NX) in NBVAL and NXVAL.
686685
*
687686
NB = NBVAL( INB )
@@ -694,10 +693,10 @@ SUBROUTINE DCHKQP3RK( DOTYPE, NM, MVAL, NN, NVAL, NNS, NSVAL,
694693

695694
*
696695
* We do MIN(M,N)+1 because we need a test for KMAX > N,
697-
* when KMAX is larger than min(M,N), KMAX should be
698-
* KMAX = min(M,N)
696+
* when KMAX is larger than MIN(M,N), KMAX should be
697+
* KMAX = MIN(M,N)
699698
*
700-
DO KMAX = 0, min(M,N)+1
699+
DO KMAX = 0, MIN(M,N)+1
701700

702701

703702

@@ -707,7 +706,7 @@ SUBROUTINE DCHKQP3RK( DOTYPE, NM, MVAL, NN, NVAL, NNS, NSVAL,
707706
* Get a working copy of COPYA into A( 1:M,1:N ).
708707
* Get a working copy of COPYB into A( 1:M, (N+1):NRHS ).
709708
* Get a working copy of COPYB into into B( 1:M, 1:NRHS ).
710-
* Get a working copy of IWORK(1:N) into
709+
* Get a working copy of IWORK(1:N) awith zeroes into
711710
* which is going to be used as pivot array IWORK( N+1:2N ).
712711
* NOTE: IWORK(2N+1:3N) is going to be used as a WORK array
713712
* for the routine.
@@ -734,7 +733,7 @@ SUBROUTINE DCHKQP3RK( DOTYPE, NM, MVAL, NN, NVAL, NNS, NSVAL,
734733
CALL DLACPY( 'All', M, NRHS, COPYB, LDA,
735734
$ B, LDA )
736735
CALL ICOPY( N, IWORK( 1 ), 1, IWORK( N+1 ), 1 )
737-
736+
*
738737
ABSTOL = -1.0
739738
RELTOL = -1.0
740739

@@ -892,17 +891,17 @@ SUBROUTINE DCHKQP3RK( DOTYPE, NM, MVAL, NN, NVAL, NNS, NSVAL,
892891
WRITE(*,*)
893892
$ TAU(1), TAU(2), TAU(3), TAU(4),
894893
$ TAU(5), TAU(6), TAU(7), TAU(8)
895-
WRITE(*,*) " "
894+
WRITE(*,*)
896895

897896
WRITE(*,*) "JPIV after DGEQP3RK"
898897
WRITE(*,*)
899898
$ IWORK(N+1), IWORK(N+2), IWORK(N+3), IWORK(N+4),
900899
$ IWORK(N+5), IWORK(N+6), IWORK(N+7), IWORK(N+8)
901-
WRITE(*,*) " "
900+
WRITE(*,*)
902901

903902
WRITE(*,*) "INFO after DGEQP3RK"
904903
WRITE(*,*) INFO
905-
WRITE(*,*) " "
904+
WRITE(*,*)
906905
*
907906
* Check error code from DGEQP3RK.
908907
*
@@ -944,6 +943,9 @@ SUBROUTINE DCHKQP3RK( DOTYPE, NM, MVAL, NN, NVAL, NNS, NSVAL,
944943
END IF
945944
END DO
946945
NRUN = NRUN + 1
946+
*
947+
* End test 1
948+
*
947949
END IF
948950
*
949951
*
@@ -1044,7 +1046,7 @@ SUBROUTINE DCHKQP3RK( DOTYPE, NM, MVAL, NN, NVAL, NNS, NSVAL,
10441046
*
10451047
* (1) Compute B:=Q**T * B in the matrix B.
10461048
*
1047-
IF( MIN(M,N).GT.0 ) THEN
1049+
IF( MINMN.GT.0 ) THEN
10481050
*
10491051

10501052
WRITE(*,*)
@@ -1059,11 +1061,10 @@ SUBROUTINE DCHKQP3RK( DOTYPE, NM, MVAL, NN, NVAL, NNS, NSVAL,
10591061
* $ ,B((11-1)*LDA+I), B((12-1)*LDA+I)
10601062
END DO
10611063
*
1062-
LWORK_DORMQR = MAX(1, NRHS)
1063-
CALL DORMQR( 'Left', 'Transpose', M, NRHS, KFACT,
1064-
$ A, LDA, TAU, B, LDA, WORK,
1065-
$ LWORK_DORMQR, INFO )
1066-
*
1064+
LWORK_DORMQR = MAX(1, NRHS)
1065+
CALL DORMQR( 'Left', 'Transpose',
1066+
$ M, NRHS, KFACT, A, LDA, TAU, B, LDA,
1067+
$ WORK, LWORK_DORMQR, INFO )
10671068
*
10681069
WRITE(*,*)
10691070
WRITE(*,*) "TEST 5: B after computing Q**T * B"
@@ -1081,12 +1082,10 @@ SUBROUTINE DCHKQP3RK( DOTYPE, NM, MVAL, NN, NVAL, NNS, NSVAL,
10811082

10821083
DO I = 1, NRHS
10831084
*
1084-
* Compare N+J-th column of A and J-column of B.
1085+
* Compare N+J-th column of A and J-column of B.
10851086
*
1086-
CALL DAXPY( M, -ONE, A( ( N+I-1 )*LDA+1 ), 1,
1087-
$ B( ( I-1 )*LDA+1 ), 1 )
1088-
1089-
1087+
CALL DAXPY( M, -ONE, A( ( N+I-1 )*LDA+1 ), 1,
1088+
$ B( ( I-1 )*LDA+1 ), 1 )
10901089
END DO
10911090
*
10921091
WRITE(*,*)
@@ -1104,7 +1103,7 @@ SUBROUTINE DCHKQP3RK( DOTYPE, NM, MVAL, NN, NVAL, NNS, NSVAL,
11041103
*
11051104
RESULT( 5 ) =
11061105
$ ABS(
1107-
$ DLANGE( 'One-norm', M, NRHS, B, M, RDUMMY ) /
1106+
$ DLANGE( 'One-norm', M, NRHS, B, LDA, RDUMMY ) /
11081107
$ ( DBLE( M )*DLAMCH( 'Epsilon' ) )
11091108
$ )
11101109

@@ -1132,7 +1131,7 @@ SUBROUTINE DCHKQP3RK( DOTYPE, NM, MVAL, NN, NVAL, NNS, NSVAL,
11321131
*
11331132
END IF
11341133
*
1135-
* END DO KMAX = 1, MAX(M,N)
1134+
* END DO KMAX = 1, MIN(M,N)+1
11361135
*
11371136
END DO
11381137
*

0 commit comments

Comments
 (0)