Skip to content

Commit 0d1e3ec

Browse files
committed
Remove auxiliary GEQRS, GELQS
GEQRS and GELQS were likely computational routines once, (they have an input argument check, which auxiliary/test routines typically do not have) but have been superseded by GELS a long time ago. The only remaining occurrences are in the tests CHKQR and CHKLQ, where they are auxiliary routines to widen the test coverage. * Replace GEQRS and GELQS by calls to GELS in tests * Remove the functions from the error exit tests * Move GEQRS and GELQS to the deprecated routines Closes #709
1 parent 8fb58fb commit 0d1e3ec

28 files changed

+144
-292
lines changed

SRC/CMakeLists.txt

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -477,17 +477,17 @@ set(ZXLASRC zgesvxx.f zgerfsx.f zla_gerfsx_extended.f zla_geamv.f
477477
zla_lin_berr.f zlarscl2.f zlascl2.f zla_wwaddw.f)
478478

479479
if(BUILD_DEPRECATED)
480-
list(APPEND SLASRC DEPRECATED/sgegs.f DEPRECATED/sgegv.f
481-
DEPRECATED/sgeqpf.f DEPRECATED/sgelsx.f DEPRECATED/sggsvd.f
480+
list(APPEND SLASRC DEPRECATED/sgegs.f DEPRECATED/sgegv.f DEPRECATED/sgelqs.f
481+
DEPRECATED/sgelsx.f DEPRECATED/sgeqpf.f DEPRECATED/sgeqrs.f DEPRECATED/sggsvd.f
482482
DEPRECATED/sggsvp.f DEPRECATED/slahrd.f DEPRECATED/slatzm.f DEPRECATED/stzrqf.f)
483-
list(APPEND DLASRC DEPRECATED/dgegs.f DEPRECATED/dgegv.f
484-
DEPRECATED/dgeqpf.f DEPRECATED/dgelsx.f DEPRECATED/dggsvd.f
483+
list(APPEND DLASRC DEPRECATED/dgegs.f DEPRECATED/dgegv.f DEPRECATED/dgelqs.f
484+
DEPRECATED/dgelsx.f DEPRECATED/dgeqpf.f DEPRECATED/dgeqrs.f DEPRECATED/dggsvd.f
485485
DEPRECATED/dggsvp.f DEPRECATED/dlahrd.f DEPRECATED/dlatzm.f DEPRECATED/dtzrqf.f)
486-
list(APPEND CLASRC DEPRECATED/cgegs.f DEPRECATED/cgegv.f
487-
DEPRECATED/cgeqpf.f DEPRECATED/cgelsx.f DEPRECATED/cggsvd.f
486+
list(APPEND CLASRC DEPRECATED/cgegs.f DEPRECATED/cgegv.f DEPRECATED/cgelqs.f
487+
DEPRECATED/cgelsx.f DEPRECATED/cgeqpf.f DEPRECATED/cgeqrs.f DEPRECATED/cggsvd.f
488488
DEPRECATED/cggsvp.f DEPRECATED/clahrd.f DEPRECATED/clatzm.f DEPRECATED/ctzrqf.f)
489-
list(APPEND ZLASRC DEPRECATED/zgegs.f DEPRECATED/zgegv.f
490-
DEPRECATED/zgeqpf.f DEPRECATED/zgelsx.f DEPRECATED/zggsvd.f
489+
list(APPEND ZLASRC DEPRECATED/zgegs.f DEPRECATED/zgegv.f DEPRECATED/zgelqs.f
490+
DEPRECATED/zgelsx.f DEPRECATED/zgeqpf.f DEPRECATED/zgeqrs.f DEPRECATED/zggsvd.f
491491
DEPRECATED/zggsvp.f DEPRECATED/zlahrd.f DEPRECATED/zlatzm.f DEPRECATED/ztzrqf.f)
492492
endif()
493493

File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

SRC/Makefile

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -515,18 +515,22 @@ ZXLASRC = zgesvxx.o zgerfsx.o zla_gerfsx_extended.o zla_geamv.o \
515515
zla_lin_berr.o zlarscl2.o zlascl2.o zla_wwaddw.o
516516
endif
517517

518-
DEPRECSRC = DEPRECATED/cgegs.o DEPRECATED/cgegv.o DEPRECATED/cgelsx.o \
519-
DEPRECATED/cgeqpf.o DEPRECATED/cggsvd.o DEPRECATED/cggsvp.o \
520-
DEPRECATED/clahrd.o DEPRECATED/clatzm.o DEPRECATED/ctzrqf.o \
521-
DEPRECATED/dgegs.o DEPRECATED/dgegv.o DEPRECATED/dgelsx.o \
522-
DEPRECATED/dgeqpf.o DEPRECATED/dggsvd.o DEPRECATED/dggsvp.o \
523-
DEPRECATED/dlahrd.o DEPRECATED/dlatzm.o DEPRECATED/dtzrqf.o \
524-
DEPRECATED/sgegs.o DEPRECATED/sgegv.o DEPRECATED/sgelsx.o \
525-
DEPRECATED/sgeqpf.o DEPRECATED/sggsvd.o DEPRECATED/sggsvp.o \
526-
DEPRECATED/slahrd.o DEPRECATED/slatzm.o DEPRECATED/stzrqf.o \
527-
DEPRECATED/zgegs.o DEPRECATED/zgegv.o DEPRECATED/zgelsx.o \
528-
DEPRECATED/zgeqpf.o DEPRECATED/zggsvd.o DEPRECATED/zggsvp.o \
529-
DEPRECATED/zlahrd.o DEPRECATED/zlatzm.o DEPRECATED/ztzrqf.o
518+
DEPRECSRC = DEPRECATED/cgegs.o DEPRECATED/cgegv.o DEPRECATED/cgelqs.o \
519+
DEPRECATED/cgelsx.o DEPRECATED/cgeqpf.o DEPRECATED/cgeqrs.o \
520+
DEPRECATED/cggsvd.o DEPRECATED/cggsvp.o DEPRECATED/clahrd.o \
521+
DEPRECATED/clatzm.o DEPRECATED/ctzrqf.o \
522+
DEPRECATED/dgegs.o DEPRECATED/dgegv.o DEPRECATED/dgelqs.o \
523+
DEPRECATED/dgelsx.o DEPRECATED/dgeqpf.o DEPRECATED/dgeqrs.o \
524+
DEPRECATED/dggsvd.o DEPRECATED/dggsvp.o DEPRECATED/dlahrd.o \
525+
DEPRECATED/dlatzm.o DEPRECATED/dtzrqf.o \
526+
DEPRECATED/sgegs.o DEPRECATED/sgegv.o DEPRECATED/sgelqs.o \
527+
DEPRECATED/sgelsx.o DEPRECATED/sgeqpf.o DEPRECATED/sgeqrs.o \
528+
DEPRECATED/sggsvd.o DEPRECATED/sggsvp.o DEPRECATED/slahrd.o \
529+
DEPRECATED/slatzm.o DEPRECATED/stzrqf.o \
530+
DEPRECATED/zgegs.o DEPRECATED/zgegv.o DEPRECATED/zgelqs.o \
531+
DEPRECATED/zgelsx.o DEPRECATED/zgeqpf.o DEPRECATED/zgeqrs.o \
532+
DEPRECATED/zggsvd.o DEPRECATED/zggsvp.o DEPRECATED/zlahrd.o \
533+
DEPRECATED/zlatzm.o DEPRECATED/ztzrqf.o
530534

531535
ALLOBJ = $(SLASRC) $(DLASRC) $(DSLASRC) $(CLASRC) $(ZLASRC) $(ZCLASRC) \
532536
$(SCLAUX) $(DZLAUX) $(ALLAUX)

0 commit comments

Comments
 (0)