query_performance_factor not optional in provider/datasource_rediscloud_pro_database.go

[mattmarich-wrstbnd]

Since provider release 2.1.2 where query_performance_factor was added to provider/datasource_rediscloud_pro_database.go, our terraform has been failing with the following:

2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: panic: runtime error: invalid memory address or nil pointer dereference
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: [signal SIGSEGV: segmentation violation code=0x2 addr=0x8 pc=0x1024f5a88]
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: goroutine 204 [running]:
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: github.com/RedisLabs/terraform-provider-rediscloud/provider.dataSourceRedisCloudProDatabaseRead({0x102a8c5d8, 0x14000162070}, 0x14000810180, {0x1029091a0?, 0x1400011a750})
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: github.com/RedisLabs/terraform-provider-rediscloud/provider/datasource_rediscloud_pro_database.go:484 +0x1a18
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0x140001c3900, {0x102a8c530, 0x140000f20c0}, 0x14000810180, {0x1029091a0, 0x1400011a750})
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: github.com/hashicorp/terraform-plugin-sdk/v2@v2.36.1/helper/schema/resource.go:855 +0xe4
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).ReadDataApply(0x140001c3900, {0x102a8c530, 0x140000f20c0}, 0x14000810080, {0x1029091a0, 0x1400011a750})
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: github.com/hashicorp/terraform-plugin-sdk/v2@v2.36.1/helper/schema/resource.go:1075 +0x110
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadDataSource(0x14000378708, {0x102a8c530?, 0x140000f2000?}, 0x14000a86450)
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: github.com/hashicorp/terraform-plugin-sdk/v2@v2.36.1/helper/schema/grpc_provider.go:1474 +0x5a4
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ReadDataSource(0x140003ce500, {0x102a8c530?, 0x14000376780?}, 0x1400082a410)
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: github.com/hashicorp/terraform-plugin-go@v0.26.0/tfprotov5/tf5server/server.go:688 +0x1d8
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadDataSource_Handler({0x102a60f60, 0x140003ce500}, {0x102a8c530, 0x14000376780}, 0x1400052aa00, 0x0)
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: github.com/hashicorp/terraform-plugin-go@v0.26.0/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:665 +0x1c0
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: google.golang.org/grpc.(*Server).processUnaryRPC(0x1400024a200, {0x102a8c530, 0x14000376720}, 0x140006146c0, 0x140003ab920, 0x1030176a0, 0x0)
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: google.golang.org/grpc@v1.69.4/server.go:1392 +0xc58
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: google.golang.org/grpc.(*Server).handleStream(0x1400024a200, {0x102a8cd48, 0x14000514000}, 0x140006146c0)
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: google.golang.org/grpc@v1.69.4/server.go:1802 +0x910
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: google.golang.org/grpc.(*Server).serveStreams.func2.1()
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: google.golang.org/grpc@v1.69.4/server.go:1030 +0x8c
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 39
2025-06-12T09:57:32.571-0500 [DEBUG] provider.terraform-provider-rediscloud_v2.1.2: google.golang.org/grpc@v1.69.4/server.go:1041 +0x13c
2025-06-12T09:57:32.572-0500 [ERROR] provider: plugin process exited: plugin=.terraform/providers/registry.terraform.io/redislabs/rediscloud/2.1.2/darwin_arm64/terraform-provider-rediscloud_v2.1.2 id=66231 error="exit status 2"

Our resource type of rediscloud_subscription_database runs fine. Staying at release 2.1.1 for now

[leonkatsevman]

Hi @mattmarich-wrstbnd , thank you for your input . please add your TF script .
Are you setting the value for query_performance_factor in your rediscloud_subscription_database resource ?
Setting query_performance_factor is allowed only with RedisSearch module

[mattmarich-wrstbnd]

@leonkatsevman

Hi @mattmarich-wrstbnd , thank you for your input . please add your TF script . Are you setting the value for query_performance_factor in your rediscloud_subscription_database resource ? Setting query_performance_factor is allowed only with RedisSearch module

We're not utilizing query_performance_factor anywhere in our redis module, we're had to stay at 2.1.1 since once it was included in the 2.1.2 release all of our terraform fails which uses the redis module. Here's the tf script for reference. Again, the resource type of rediscloud_subscription_database works fine but the data type of rediscloud_database fails

`resource "rediscloud_subscription_database" "redis-database" {
count = var.enable-redis == true ? 1 : 0
name = var.name
data_persistence = "snapshot-every-1-hour"
memory_limit_in_gb = var.redis-override_memory-limit-in-gb
replication = true
subscription_id = var.redis-subscription
throughput_measurement_by = "operations-per-second"
throughput_measurement_value = var.redis-override_operations-per-second

remote_backup {
interval = "every-24-hours"
storage_path = "s3:///${var.name}"
storage_type = "aws-s3"
}
}

data "rediscloud_database" "redis-database" {
count = var.enable-redis == true ? 1 : 0
name = var.name
subscription_id = var.redis-subscription
depends_on = [rediscloud_subscription_database.redis-database]
}
`

This has to deal directly with what was changed in 2.1.2