Skip to content

Commit eed1896

Browse files
authored
Merge pull request #218 from hwpang/rmgmolecule
Fixing dependency conflicts
2 parents b64f6d4 + 8fa7f60 commit eed1896

File tree

6 files changed

+21
-19
lines changed

6 files changed

+21
-19
lines changed

.github/workflows/documentation.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ on:
99

1010
jobs:
1111
build:
12+
permissions:
13+
contents: write
1214
runs-on: ubuntu-latest
1315
steps:
1416
- uses: actions/checkout@v2
@@ -23,7 +25,7 @@ jobs:
2325
- name: Install dependencies
2426
run: |
2527
julia -e 'ENV["PYTHON"]=ENV["CONDA"] * "/envs/rms_env/bin/python"; using Pkg; Pkg.add("PyCall"); Pkg.build("PyCall")'
26-
julia --project=docs/ -e 'using Pkg; Pkg.add(PackageSpec(name="StochasticDiffEq",version="6.36.0")); Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate();'
28+
julia --project=docs/ -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate();'
2729
- name: Build and deploy
2830
env:
2931
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # For authentication with GitHub Actions token

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name = "ReactionMechanismSimulator"
22
uuid = "c2d78dd2-25c4-5b79-bebc-be6c69dd440f"
3-
authors = ["Matt Johnson <mjohnson541@gmail.com>"]
3+
authors = ["Matt Johnson <mjohnson541@gmail.com>", "Hao-Wei Pang <hao4wei3pang2@gmail.com>"]
44
version = "0.4.0"
55

66
[deps]

deps/build.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ if PyCall.pyversion.major != 3 || PyCall.pyversion.minor != 7
99
end
1010
Conda.add("nomkl")
1111
Conda.add("numpy")
12-
Conda.add_channel("rmg")
13-
Conda.add("rmg")
12+
Conda.add_channel("hwpang")
13+
Conda.add("rmgmolecule")
1414
Pkg.build("PyCall")
1515
end

environment.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
name: rms_env
22
channels:
33
- defaults
4+
- hwpang
45
- rmg
6+
- conda-forge
57
dependencies:
68
- rdkit
7-
- rmg
9+
- hwpang::rmgmolecule
810
- pydot
9-
- yaml
11+
- matplotlib

src/ReactionMechanismSimulator.jl

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,23 +14,21 @@ module ReactionMechanismSimulator
1414
const falloff = PyNULL()
1515
const chebyshev = PyNULL()
1616
const solvation = PyNULL()
17-
const yaml = PyNULL()
1817
const os = PyNULL()
1918
function __init__()
2019
copy!(Chem,pyimport_conda("rdkit.Chem","rdkit","rmg"))
2120
copy!(Desc,pyimport_conda("rdkit.Chem.Descriptors","rdkit","rmg"))
22-
copy!(molecule,pyimport_conda("rmgpy.molecule","rmg","rmg"))
21+
copy!(molecule,pyimport_conda("molecule.molecule","rmgmolecule","hwpang"))
2322
copy!(pydot,pyimport_conda("pydot","pydot"))
24-
copy!(chemkin,pyimport_conda("rmgpy.chemkin","rmg","rmg"))
25-
copy!(species,pyimport_conda("rmgpy.species","rmg","rmg"))
26-
copy!(reaction,pyimport_conda("rmgpy.reaction","rmg","rmg"))
27-
copy!(nasa,pyimport_conda("rmgpy.thermo.nasa","rmg","rmg"))
28-
copy!(wilhoit,pyimport_conda("rmgpy.thermo.wilhoit","rmg","rmg"))
29-
copy!(arrhenius,pyimport_conda("rmgpy.kinetics.arrhenius","rmg","rmg"))
30-
copy!(falloff,pyimport_conda("rmgpy.kinetics.falloff","rmg","rmg"))
31-
copy!(chebyshev,pyimport_conda("rmgpy.kinetics.chebyshev","rmg","rmg"))
32-
copy!(solvation,pyimport_conda("rmgpy.data.solvation","rmg","rmg"))
33-
copy!(yaml,pyimport_conda("yaml","yaml"))
23+
copy!(chemkin,pyimport_conda("molecule.chemkin","rmgmolecule","hwpang"))
24+
copy!(species,pyimport_conda("molecule.species","rmgmolecule","hwpang"))
25+
copy!(reaction,pyimport_conda("molecule.reaction","rmgmolecule","hwpang"))
26+
copy!(nasa,pyimport_conda("molecule.thermo.nasa","rmgmolecule","hwpang"))
27+
copy!(wilhoit,pyimport_conda("molecule.thermo.wilhoit","rmgmolecule","hwpang"))
28+
copy!(arrhenius,pyimport_conda("molecule.kinetics.arrhenius","rmgmolecule","hwpang"))
29+
copy!(falloff,pyimport_conda("molecule.kinetics.falloff","rmgmolecule","hwpang"))
30+
copy!(chebyshev,pyimport_conda("molecule.kinetics.chebyshev","rmgmolecule","hwpang"))
31+
copy!(solvation,pyimport_conda("molecule.data.solvation","rmgmolecule","hwpang"))
3432
copy!(os,pyimport_conda("os","os"))
3533
end
3634
include("Constants.jl")

src/rmstest.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const Chem = PyNULL()
33
const molecule = PyNULL()
44
const pydot = PyNULL()
55
copy!(Chem,pyimport_conda("rdkit.Chem","rdkit","rmg"))
6-
copy!(molecule,pyimport_conda("rmgpy.molecule","rmgpy","rmg"))
6+
copy!(molecule, pyimport_conda("molecule.molecule", "rmgmolecule", "hwpang"))
77
copy!(pydot,pyimport_conda("pydot","pydot","rmg"))
88

99

0 commit comments

Comments
 (0)