Skip to content

Ring corrections defined different java <-> python version #158

@agvandeputte

Description

@agvandeputte

I noticed that when calculating thermo on dev.rmg.mit.edu, gauche corrections are added to rings while in java ring corrections are omitted completely for ring containing species.

Somehow I feel that the java approach is the easiest way to go and define ring corrections relating to the "strain free open ring analogue". Although someone will have to rewrite the code that the ring structure gets recognized and all internal gauche /cis/1,5 corrections are discarded while external effect in branches and between branches and the ring should still be accounted for.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions