Skip to content

Commit f14c6ca

Browse files
committed
Code review fixes
1 parent 68fd5b5 commit f14c6ca

File tree

3 files changed

+19
-20
lines changed

3 files changed

+19
-20
lines changed

src/decorators/customEvent.js

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -34,24 +34,23 @@ const setUntargetItems = function (currentTarget, targetArray) {
3434
}
3535

3636
const customListeners = {
37-
registry: new WeakMap(),
37+
id: '9b69f92e-d3fe-498b-b1b4-c5e63a51b0cf',
3838
set (target, event, listener) {
39-
if (this.registry.has(target)) {
40-
const map = this.registry.get(target)
39+
if (this.id in target) {
40+
const map = target[this.id]
4141
map[event] = listener
42-
return this.registry
42+
} else {
43+
Object.defineProperty(target, this.id, {
44+
configurable: true,
45+
value: { [event]: listener }
46+
})
4347
}
44-
45-
return this.registry.set(target, { [event]: listener })
4648
},
47-
4849
get (target, event) {
49-
const map = this.registry.get(target)
50+
const map = target[this.id]
5051
if (map !== undefined) {
5152
return map[event]
5253
}
53-
54-
return void 0
5554
}
5655
}
5756

standalone/react-tooltip.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1306,23 +1306,23 @@ var setUntargetItems = function setUntargetItems(currentTarget, targetArray) {
13061306
};
13071307

13081308
var customListeners = {
1309-
registry: new WeakMap(),
1309+
id: '9b69f92e-d3fe-498b-b1b4-c5e63a51b0cf',
13101310
set: function set(target, event, listener) {
1311-
if (this.registry.has(target)) {
1312-
var map = this.registry.get(target);
1311+
if (this.id in target) {
1312+
var map = target[this.id];
13131313
map[event] = listener;
1314-
return this.registry;
1314+
} else {
1315+
Object.defineProperty(target, this.id, {
1316+
configurable: true,
1317+
value: _defineProperty({}, event, listener)
1318+
});
13151319
}
1316-
1317-
return this.registry.set(target, _defineProperty({}, event, listener));
13181320
},
13191321
get: function get(target, event) {
1320-
var map = this.registry.get(target);
1322+
var map = target[this.id];
13211323
if (map !== undefined) {
13221324
return map[event];
13231325
}
1324-
1325-
return void 0;
13261326
}
13271327
};
13281328

0 commit comments

Comments
 (0)