Skip to content

Commit 2c57366

Browse files
committed
refactor: contributing readme updated
1 parent 356821b commit 2c57366

File tree

3 files changed

+25
-18
lines changed

3 files changed

+25
-18
lines changed

.travis.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,13 @@ script:
2323
- yarn
2424
- yarn build
2525

26-
deploy:
27-
provider: pages
28-
skip_cleanup: true
29-
token: $GH_TOKEN
30-
keep_history: true
31-
on:
32-
branch: refactoring
26+
#deploy:
27+
# provider: pages
28+
# skip_cleanup: true
29+
# token: $GH_TOKEN
30+
# keep_history: true
31+
# on:
32+
# branch: refactoring
3333

3434
after_success:
3535
- yarn semantic-release

contributing.md

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,31 @@ This doc needs help! Please submit your PR...
44

55
## Commit messages
66

7-
We are using semantic-release to automate the release process, and this depends on a specific format for commit messages. Please run `npm run commit` to use `commitizen` to properly format your commit messages so they can be automatically processed and included in release notes.
7+
We are using semantic-release to automate the release process, and this depends on a specific format for commit messages. Please run `yarn commit` to use `commitizen` to properly format your commit messages so they can be automatically processed and included in release notes.
88

99
## Pull request testing
1010

1111
Some notes on testing and releasing.
1212
* For a PR, follow Github's command-line instructions for retrieving the branch with the changes.
13-
* `make dev` starts a development server, open `http://localhost:8888` to see the example website.
13+
* To start a development server:
14+
15+
```sh
16+
yarn build
17+
cd example
18+
yarn
19+
yarn start
20+
```
21+
1422
* Provide feedback on the PR about your results.
1523

1624
## Doing a release
1725

1826
We are using semantic-release instead of this:
1927

20-
* `make deploy` updates the files in the `standalone` directory
2128
* update the version number in `package.json`
22-
- Fixes update the patch number, features update the minor number.
23-
- Major version update is reserved for API breaking changes, not just additions.
24-
* `npm run github-changes -- -n 3.X.Y` to update the changelog
29+
- Fixes update the patch number, features update the minor number.
30+
- Major version update is reserved for API breaking changes, not just additions.
31+
* `yarn github-changes -- -n 3.X.Y` to update the changelog
2532
* `git add`, `git commit` and `git push` to get the version to master.
2633
* `git tag -a 3.X.Y -m 3.X.Y` `git push --tags`
2734
* `npm publish`

example/src/App.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ export default class App extends Component {
217217
{'(〃∀〃)'}
218218
</a>
219219
</div>
220-
<ReactTooltip id="global" aria-haspopup="true" role="example">
220+
<ReactTooltip id="global" aria-haspopup="true">
221221
<p>This is a global react component tooltip</p>
222222
<p>You can put every thing here</p>
223223
<ul>
@@ -232,7 +232,7 @@ export default class App extends Component {
232232
<p>
233233
{"<a data-tip data-for='global'> σ`∀´)σ </a>\n" +
234234
"<a data-tip data-for='global'> (〃∀〃) </a>\n" +
235-
"<ReactTooltip id='global' aria-haspopup='true' role='example'>\n" +
235+
"<ReactTooltip id='global' aria-haspopup='true' >\n" +
236236
" <p>This is a global react component tooltip</p>\n" +
237237
" <p>You can put every thing here</p>\n" +
238238
" <ul>\n" +
@@ -430,7 +430,7 @@ export default class App extends Component {
430430
<p>
431431
{"<a data-for='enrich' data-tip='sooooo cute'>(❂‿❂)</a>\n" +
432432
"<a data-for='enrich' data-tip='really high'>(❂‿❂)</a>\n" +
433-
"<ReactTooltip id='enrich' getContent={(dataTip) => `This little buddy is ${dataTip}`}/>"}
433+
`<ReactTooltip id='enrich' getContent={(dataTip) => \`This little buddy is \${dataTip}\`}/>`}
434434
</p>
435435
</div>
436436
</pre>
@@ -738,7 +738,7 @@ export default class App extends Component {
738738
<div>header</div>
739739
<img
740740
src="http://lorempixel.com/100/1500"
741-
alt="lorem image 100x1500"
741+
alt="lorem 100x1500"
742742
/>
743743
<div>footer</div>
744744
</ReactTooltip>
@@ -749,7 +749,7 @@ export default class App extends Component {
749749
<div>header</div>
750750
<img
751751
src="http://lorempixel.com/100/1500"
752-
alt="lorem image 100x1500"
752+
alt="lorem 100x1500"
753753
/>
754754
<div>footer</div>
755755
</ReactTooltip>

0 commit comments

Comments
 (0)