Update ci.yml

Author: Rashed-alothman

.github/workflows/ci.yml

@@ -11,6 +11,7 @@ on:
       - "interactive_mode.py"
       - "test_run.py"
       - "requirements.txt"
+      - "tests/**"
       - ".github/workflows/**"
   pull_request:
     branches:
@@ -22,10 +23,11 @@ on:
       - "interactive_mode.py"
       - "test_run.py"
       - "requirements.txt"
+      - "tests/**"
       - ".github/workflows/**"
   schedule:
-    - cron: "0 0 * * 0" # Run weekly on Sundays
-  workflow_dispatch: # Allow manual triggering
+    - cron: "0 0 * * 0" # Weekly on Sundays
+  workflow_dispatch:
 
 jobs:
   lint:
@@ -39,54 +41,92 @@ jobs:
         uses: actions/setup-python@v5
         with:
           python-version: "3.10"
-          cache: "pip" # Enable pip caching
+          cache: "pip"
 
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
           pip install flake8 black isort pylint
-          if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
+          pip install -r requirements.txt
+
+      # Set up .pylintrc if it doesn't exist
+      - name: Configure Pylint
+        run: |
+          if [ ! -f .pylintrc ]; then
+            echo "[MASTER]
+            init-hook='import sys; sys.path.append(\".\")'
+            
+            [MESSAGES CONTROL]
+            disable=C0111,C0103,C0303,C0330,C0326,W0511,R0903,R0913,R0914,R0912,R0915,R0902,R0801,W0212,W0703,C0111,C0103,C0303,C0330,C0326
+            
+            [FORMAT]
+            max-line-length=127" > .pylintrc
+          fi
 
       - name: Check formatting with Black
-        run: black --check Snatch.py setup.py setup_ffmpeg.py interactive_mode.py test_run.py
+        id: black
+        run: |
+          black --check --diff .
         continue-on-error: true
 
+      - name: Fix formatting with Black if check fails
+        if: steps.black.outcome == 'failure'
+        run: |
+          black .
+          git config --global user.name "GitHub Actions"
+          git config --global user.email "actions@github.com"
+          git add .
+          git commit -m "Fix code formatting with Black" || echo "No changes to commit"
+
       - name: Check imports with isort
-        run: isort --check-only --profile black Snatch.py setup.py setup_ffmpeg.py interactive_mode.py test_run.py
+        id: isort
+        run: |
+          isort --check-only --profile black .
         continue-on-error: true
 
+      - name: Fix imports with isort if check fails
+        if: steps.isort.outcome == 'failure'
+        run: |
+          isort --profile black .
+          git config --global user.name "GitHub Actions"
+          git config --global user.email "actions@github.com"
+          git add .
+          git commit -m "Fix imports with isort" || echo "No changes to commit"
+
       - name: Lint with flake8
         run: |
           # Stop the build if there are Python syntax errors or undefined names
-          flake8 Snatch.py setup.py setup_ffmpeg.py interactive_mode.py test_run.py --count --select=E9,F63,F7,F82 --show-source --statistics
-          # Exit-zero treats all errors as warnings
-          flake8 Snatch.py setup.py setup_ffmpeg.py interactive_mode.py test_run.py --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+          flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
+          # Full check with exit-zero treats all errors as warnings
+          flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+        continue-on-error: true
 
-      - name: Check with pylint
+      - name: Run pylint
         run: |
-          pylint --disable=all --enable=unused-import,unused-variable,unused-argument,undefined-variable Snatch.py setup.py setup_ffmpeg.py interactive_mode.py test_run.py
+          pylint --recursive=y --output-format=colorized . || echo "Pylint completed with warnings/errors"
         continue-on-error: true
 
-      - name: Generate linting reports
+      - name: Generate code quality reports
         run: |
           mkdir -p reports
-          flake8 Snatch.py setup.py setup_ffmpeg.py interactive_mode.py test_run.py --output-file=reports/flake8.txt
-          pylint Snatch.py setup.py setup_ffmpeg.py interactive_mode.py test_run.py -f json > reports/pylint.json || true
+          flake8 . --output-file=reports/flake8.txt --exit-zero
+          pylint --recursive=y . -f json > reports/pylint.json || true
 
-      - name: Upload linting reports
+      - name: Upload code quality reports
         uses: actions/upload-artifact@v4
         with:
-          name: linting-reports
+          name: code-quality-reports
           path: reports/
+          retention-days: 14
 
   test:
-    name: Test
+    name: Test on ${{ matrix.os }} with Python ${{ matrix.python-version }}
     runs-on: ${{ matrix.os }}
     needs: lint
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest]
-        python-version: ["3.8", "3.9", "3.10", "3.11"]
+        python-version: ["3.8", "3.10", "3.11"]
       fail-fast: false
 
     steps:
@@ -102,8 +142,8 @@ jobs:
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install pytest pytest-cov
-          if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
+          pip install pytest pytest-cov pytest-xdist pytest-html
+          pip install -r requirements.txt
         shell: bash
 
       - name: Install FFmpeg (Ubuntu)
@@ -116,35 +156,53 @@ jobs:
         if: matrix.os == 'windows-latest'
         run: |
           choco install ffmpeg -y
+          # Fix potential PATH issues
+          echo "$env:ProgramData\chocolatey\bin" | Out-File -FilePath $env:GITHUB_PATH -Append
+        shell: pwsh
 
       - name: Verify FFmpeg installation
         run: |
           ffmpeg -version
         shell: bash
+        continue-on-error: true
 
-      - name: Run basic tests
+      - name: Create directories
         run: |
-          python test_run.py
-        continue-on-error: true
+          mkdir -p test_output tests
+          if [ ! -f tests/__init__.py ]; then touch tests/__init__.py; fi
+        shell: bash
 
-      - name: Test with pytest if available
+      # Create basic test file if none exists
+      - name: Create basic test file if needed
         run: |
-          if [ -d "tests" ]; then 
-            pytest --cov=. --cov-report=xml
-          else
-            echo "No tests directory found. Skipping pytest."
-            echo "Consider adding proper tests for better code quality."
+          if [ ! -f tests/test_basic.py ]; then
+            echo '
+          import sys
+          import os
+          import pytest
+
+          sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
+
+          def test_import():
+              """Test that the main module can be imported."""
+              try:
+                  import Snatch
+                  assert Snatch.__name__ == "Snatch"
+              except ImportError:
+                  pytest.skip("Snatch module not found")
+          ' > tests/test_basic.py
           fi
         shell: bash
+
+      - name: Run basic tests
+        run: |
+          python test_run.py
         continue-on-error: true
 
-      - name: Upload coverage to Codecov
-        uses: codecov/codecov-action@v3
-        with:
-          file: ./coverage.xml
-          flags: ${{ matrix.os }},python${{ matrix.python-version }}
-          name: ${{ matrix.os }}-python${{ matrix.python-version }}
-          fail_ci_if_error: false
+      - name: Test with pytest
+        run: |
+          pytest --cov=. --cov-report=xml --cov-report=html --junitxml=junit/test-results.xml --html=pytest_report.html
+        shell: bash
         continue-on-error: true
 
       - name: Upload test results
@@ -154,13 +212,14 @@ jobs:
           name: test-results-${{ matrix.os }}-py${{ matrix.python-version }}
           path: |
             coverage.xml
-            pytest-report.html
-            test_output.log
-          retention-days: 7
-        continue-on-error: true
+            htmlcov/
+            pytest_report.html
+            junit/
+            test_output/
+          retention-days: 14
 
   security-scan:
-    name: Security Scanning
+    name: Security Scan
     runs-on: ubuntu-latest
     needs: lint
     steps:
@@ -176,24 +235,25 @@ jobs:
         run: |
           python -m pip install --upgrade pip
           pip install bandit safety
+          pip install -r requirements.txt
 
       - name: Run Bandit security scanner
         run: |
-          bandit -r Snatch.py setup.py setup_ffmpeg.py interactive_mode.py -f json -o bandit-results.json
+          mkdir -p security_reports
+          bandit -r . -f json -o security_reports/bandit-results.json -x tests,venv,.venv
         continue-on-error: true
 
       - name: Check dependencies for vulnerabilities
         run: |
-          safety check -r requirements.txt --output json --save safety-results.json
+          safety check -r requirements.txt --output json --save security_reports/safety-results.json || true
         continue-on-error: true
 
       - name: Upload security scan results
         uses: actions/upload-artifact@v4
         with:
           name: security-scan-results
-          path: |
-            bandit-results.json
-            safety-results.json
+          path: security_reports/
+          retention-days: 14
 
   build:
     name: Build Package
@@ -203,7 +263,7 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v4
         with:
-          fetch-depth: 0 # Fetch all history for proper versioning
+          fetch-depth: 0
 
       - name: Set up Python
         uses: actions/setup-python@v5
@@ -218,22 +278,22 @@ jobs:
 
       - name: Build package
         run: |
-          python setup.py sdist bdist_wheel
+          python -m build --sdist --wheel .
 
       - name: Check package with twine
         run: |
           twine check dist/*
-        continue-on-error: true
 
       - name: Store built package
         uses: actions/upload-artifact@v4
         with:
           name: dist
           path: dist/
+          retention-days: 30
 
       - name: Test installation from wheel
         run: |
-          pip install dist/*.whl
+          pip install --force-reinstall dist/*.whl
 
   readme-badge:
     name: Update README Badge
@@ -257,3 +317,23 @@ jobs:
           label: CI
           message: passing
           color: green
+
+  notify:
+    name: Notify on completion
+    needs: [build, readme-badge]
+    if: always()
+    runs-on: ubuntu-latest
+    steps:
+      - name: Set job status
+        id: status
+        run: |
+          if [[ "${{ needs.build.result }}" == "success" ]]; then
+            echo "STATUS=✅ CI Pipeline completed successfully" >> $GITHUB_OUTPUT
+          else
+            echo "STATUS=⚠️ CI Pipeline completed with issues" >> $GITHUB_OUTPUT
+          fi
+
+      - name: Print completion message
+        run: |
+          echo "${{ steps.status.outputs.STATUS }}"
+          echo "All artifacts have been uploaded and are available in the Actions tab"