It works again. Extend testing to catch possible errors with it

Author: RaphaelIT7

_testing/gmod_testing.lua

@@ -119,6 +119,24 @@ local ret, err = pcall(function()
 	iFace:RunFile("includes/init.lua")
 	iFace:RunString(code)
 	iFace:RunHook("ExampleHook", "ExampleArg", 1234, true, Vector(1, 2, 3), Angle(4, 5, 6))
+
+	local startTime = SysTime()
+	for k=1, 100000 do 
+		LuaThreaded.SetValue(k, "Some Random String")
+	end
+	local endTime = SysTime()
+	print("Added 100.000 keys in " .. endTime - startTime .. "s")
+
+	local startTime = SysTime()
+	for k=1, 100000 do 
+		LuaThreaded.SetValue(k, nil)
+	end
+	local endTime = SysTime()
+	print("Removed 100.000 keys in " .. endTime - startTime .. "s")
+
+	if LuaThreaded.GetValue(1000) != nil then
+		error("LuaThreaded.SetValue failed! Investigate!")
+	end
 end)
 
 if err then

source/lua_LuaThread.cpp

@@ -107,15 +107,20 @@ LUA_FUNCTION(LuaThread_SetValue)
 	if (type == GarrysMod::Lua::Type::Nil)
 	{
 		shared_table_mutex.Lock();
+		ILuaValue* pKey = nullptr;
+		ILuaValue* pVal = nullptr;
 		for (auto& [sKey, sVal] : shared_table)
 		{
 			if (EqualValue(key, sKey))
 			{
-				SafeDelete(sKey);
-				SafeDelete(sVal);
+				pKey = sKey;
+				pVal = sVal;
 				break;
 			}
 		}
+
+		SafeDelete(pKey);
+		SafeDelete(pVal);
 		shared_table_mutex.Unlock();
 		SafeDelete(key);
 
@@ -139,9 +144,6 @@ LUA_FUNCTION(LuaThread_SetValue)
 	{
 		delete key;
 		key = original_key;
-		Msg("Found the original key.\n");
-	} else {
-		Msg("Didn't find the original key.\n");
 	}
 
 	ILuaValue* val = original_value ? original_value : new ILuaValue;