Skip to content

Rename all the badly named functions in each module and add unit tests #19

@axiezai

Description

@axiezai

List of things that need to be renamed:


  • filters.py/get_freq_spectrum_notdict - incorporate this as boolean option in get_freq_spectrum, and rename to get_frequency_spectrum
  • permute.py/reorder_connectome - this function seems oddly specific to desikan-killiany ordering, maybe rename to something related to DK.
  • there's a replicate get_freq_spectrum in preprocess.py
  • maybe it's worthwhile to rename preprocess/preprocess.py
  • we should consider removing read/data_reader.py all together, they are too specific for our use case
  • eigenmode.py needs an overhaul, @axiezai
  • laplacian.py needs renames for functions that gets complex/regular and one specific function for spectral graph model that needs frequency as an input
  • network_transfer.py has 2 network transfer functions, need to do the same as laplacian for the alpha parameters
  • run pylint after everything is done

Metadata

Metadata

Labels

documentationImprovements or additions to documentationgood first issueGood for newcomershelp wantedExtra attention is needed

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions