Allow ASG tags to propagate at launch

[joverman-collective]

To help with cost allocation reporting, it would be helpful to have some tags applied to the EC2 instances created by the ASG at launch. It seems here, it's hardcoded to false and only the Name tag is allowed to propagate:

Reference

  dynamic "tag" {
    for_each = var.tags

    content {
      key                 = tag.key
      value               = tag.value
      propagate_at_launch = false
    }
  }

We could perhaps add a new variable such as propagted_tags to allow for both propagated and non-propagated tags to not break existing functionality while allowing for extra propagated tags as well.

[DenisMkS]

try default tags

[renbeynolds]

@DenisMkS default_tags alone still are not enough to provide this behavior. There's even official Terraform documentation covering this use case. Being unable to control tagging of the launched instances is a major shortcoming of this module in a corporate setting where tags are used for cost allocation.

[RaJiska]

Hi,

Thank you for raising the issue @joverman-collective, and @joverman-collective for the PR.

As a simpler alternative how about flipping this propagation tag to true, and having the for_each loop over the tags after removing the Name tag (if exists)? I honestly can't remember why the propagation is not already set to true.