Skip to content

Commit 0ceaebf

Browse files
authored
[BugFix] Fix ordering of KVConnector finished send/rcv sets (vllm-project#18211)
Signed-off-by: Nick Hill <nhill@redhat.com>
1 parent 1db4f47 commit 0ceaebf

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

vllm/distributed/kv_transfer/kv_connector/v1/base.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,8 @@ def get_finished(
183183
finished generating tokens.
184184
185185
Returns:
186-
ids of requests that have finished asynchronous (recving, sending).
186+
ids of requests that have finished asynchronous transfer,
187+
tuple of (sending/saving ids, recving/loading ids).
187188
The finished saves/sends req ids must belong to a set provided in a
188189
call to this method (this call or a prior one).
189190
"""

vllm/distributed/kv_transfer/kv_connector/v1/multi_connector.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,10 @@ def wait_for_save(self):
103103
def get_finished(
104104
self, finished_req_ids: set[str]
105105
) -> tuple[Optional[set[str]], Optional[set[str]]]:
106-
finished_recving: set[str] = set()
107106
finished_sending: set[str] = set()
107+
finished_recving: set[str] = set()
108108
for c in self._connectors:
109-
recving, sending = c.get_finished(finished_req_ids)
109+
sending, recving = c.get_finished(finished_req_ids)
110110
if not recving and not sending:
111111
continue
112112
# Aggregate finished recving request ids.
@@ -125,7 +125,7 @@ def get_finished(
125125
else:
126126
self._extra_async_saves[req_id] = extra_pending - 1
127127

128-
return finished_recving or None, finished_sending or None
128+
return finished_sending or None, finished_recving or None
129129

130130
# ==============================
131131
# Scheduler-side methods

0 commit comments

Comments
 (0)