Skip to content

Commit 4eb64fe

Browse files
committed
Temporarily skip hipGraph version of LargeIndices test
Currently there appear to be some problems calling the atomicAdd function within hipGraphs on some architectures. The atomicAdd function is called within the device_adjacent_difference algorithm's LargeIndices test (check_output class) to increment a counter value. As a result, the hipGraph version of the test fails when called on affected architectures. This change temporarily skips the hipGraph version of the test. We can re-enable it when the root cause has been addressed.
1 parent 8b86fed commit 4eb64fe

File tree

1 file changed

+3
-18
lines changed

1 file changed

+3
-18
lines changed

test/rocprim/test_device_adjacent_difference.cpp

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -460,25 +460,10 @@ TYPED_TEST_SUITE(RocprimDeviceAdjacentDifferenceLargeTests,
460460

461461
TYPED_TEST(RocprimDeviceAdjacentDifferenceLargeTests, LargeIndices)
462462
{
463-
const int device_id = test_common_utils::obtain_device_from_ctest();
464-
465-
#ifdef _WIN32
466463
if (TestFixture::use_graphs)
467-
{
468-
// Skip this test on Navi2x/3x on Windows, since check_output_iterator does not appear to work there.
469-
hipDeviceProp_t props;
470-
HIP_CHECK(hipGetDeviceProperties(&props, device_id));
471-
std::string deviceName = std::string(props.gcnArchName);
472-
if(deviceName.rfind("gfx1030", 0) == 0 ||
473-
deviceName.rfind("gfx1100", 0) == 0 ||
474-
deviceName.rfind("gfx1101", 0) == 0 ||
475-
deviceName.rfind("gfx1102", 0) == 0)
476-
{
477-
// This is a Navi2x/3x device, so skip this test
478-
GTEST_SKIP() << "Temporarily skipping test on Windows for on gfx1030, gfx1100, gfx1101, gfx1102";
479-
}
480-
}
481-
#endif
464+
GTEST_SKIP() << "Temporarily skipping test within hipGraphs. Will re-enable when issues with atomics inside graphs are resolved.";
465+
466+
const int device_id = test_common_utils::obtain_device_from_ctest();
482467

483468
SCOPED_TRACE(testing::Message() << "with device_id = " << device_id);
484469
HIP_CHECK(hipSetDevice(device_id));

0 commit comments

Comments
 (0)