Remove deprecated wmic dependency #286
Conversation
|
Thanks for the heads up on the deprecation and the submission! The truncation of output with the PowerShell command removes a good chunk of the driver path. Could you set |
|
@harkgill-amd thank you for your comments! applied. Hope that 1000 would be enough for various driver paths |
amd/hipcc/src/hipBin_base.h
Outdated
| system("powershell -c \"Get-CIMInstance -query 'SELECT * FROM win32_VideoController' | " | ||
| "ft AdapterCompatibility,InstalledDisplayDrivers,Name\" | " | ||
| "findstr /B /C:\"Advanced Micro Devices\" | " | ||
| "Out-String -Width 1000"); |
There was a problem hiding this comment.
Out-String isn't being included in the powershell portion of the command - this'll be interpreted as CMD line and throw an error.
It should be the following
system("powershell -c \"Get-CIMInstance -query 'SELECT * FROM win32_VideoController' | "
"ft AdapterCompatibility,InstalledDisplayDrivers,Name\ | "
"Out-String -Width 1000 | findstr /B /C:\'Advanced Micro Devices'\"");
Width of 1000 LGTM.
There was a problem hiding this comment.
My bad misplaced it. Corrected now
There was a problem hiding this comment.
Is hipconfig working on your end after these changes? From what I can see,
- The powershell command is still being closed early due to the
"afterName. - findstr is not parsing
/C:\"Advanced Micro Devices\"correctly.
I'm not entirely sure why the double quotes aren't working correctly despite it being used in the wmic findstr command as well. If you could confirm that hipconfig correctly outputs the driver path, I'm good to approve this. For reference, findstr /B /C:\'Advanced Micro Devices' worked on my end.
There was a problem hiding this comment.
@harkgill-amd my laptop died so I was using win cmd to troubleshoot. I've checked the new version of the command and below works fine so I implemented it:
powershell -c "Get-CIMInstance -query 'SELECT * FROM win32_VideoController' | ft AdapterCompatibility,InstalledDisplayDrivers,Name | Out-String -Width 1000 | findstr /B /C:'Advanced Micro Devices'"
Porting #286 by @andrei-kochin Reason: Deprecation notice Partly addresses the ROCm/TheRock#1106 in llvm-project Output remains same: ``` == Windows Display Drivers Hostname :akochin Advanced Micro Devices, Inc. C:\WINDOWS\System32\DriverStore\FileRepository\u0414593.inf_amd64_f2aefb5d22f93ac9\B413...
|
Ported and merged internally with 59d82da as this fork does not yet accept external PRs. |
2 participants
Reason: Deprecation notice
Partly addresses the ROCm/TheRock#1106 in llvm-project
Output remains same: