Skip to content

Commit cd00ad4

Browse files
committed
[Comgr] Add -nogpu options to HIP tests
Now that we no longer pass -nogpuinc by default for HIP compilations (#f5f4090), we need to pass it manually for these tests
1 parent 5112f90 commit cd00ad4

File tree

4 files changed

+24
-5
lines changed

4 files changed

+24
-5
lines changed

amd/comgr/test/compile_hip_test.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@ int main(int Argc, char *Argv[]) {
4747
DataSetReloc, DataSetExec;
4848
amd_comgr_action_info_t ActionInfo;
4949
amd_comgr_status_t Status;
50+
const char *CompileOptions[] = {"-nogpulib", "-nogpuinc"};
51+
size_t CompileOptionsCount =
52+
sizeof(CompileOptions) / sizeof(CompileOptions[0]);
5053

5154
SizeSource = setBuf(TEST_OBJ_DIR "/source1.hip", &BufSource);
5255

@@ -69,6 +72,9 @@ int main(int Argc, char *Argv[]) {
6972
Status = amd_comgr_action_info_set_isa_name(ActionInfo,
7073
"amdgcn-amd-amdhsa--gfx906");
7174
checkError(Status, "amd_comgr_action_info_set_isa_name");
75+
Status = amd_comgr_action_info_set_option_list(ActionInfo, CompileOptions,
76+
CompileOptionsCount);
77+
checkError(Status, "amd_comgr_action_info_set_option_list");
7278

7379
Status = amd_comgr_create_data_set(&DataSetBc);
7480
checkError(Status, "amd_comgr_create_data_set");

amd/comgr/test/compile_hip_to_relocatable.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,10 @@ int main(int argc, char *argv[]) {
4646
amd_comgr_data_set_t DataSetIn, DataSetReloc, DataSetExec;
4747
amd_comgr_action_info_t DataAction;
4848
amd_comgr_status_t Status;
49-
const char *CodeGenOptions[] = {"-fno-slp-vectorize"};
50-
size_t CodeGenOptionsCount =
51-
sizeof(CodeGenOptions) / sizeof(CodeGenOptions[0]);
49+
const char *CompileOptions[] = {"-fno-slp-vectorize", "-nogpulib",
50+
"-nogpuinc"};
51+
size_t CompileOptionsCount =
52+
sizeof(CompileOptions) / sizeof(CompileOptions[0]);
5253

5354
SizeSource = setBuf(TEST_OBJ_DIR "/source1.hip", &BufSource);
5455

@@ -76,8 +77,8 @@ int main(int argc, char *argv[]) {
7677
"amdgcn-amd-amdhsa--gfx906");
7778
checkError(Status, "amd_comgr_action_info_set_isa_name");
7879

79-
Status = amd_comgr_action_info_set_option_list(DataAction, CodeGenOptions,
80-
CodeGenOptionsCount);
80+
Status = amd_comgr_action_info_set_option_list(DataAction, CompileOptions,
81+
CompileOptionsCount);
8182
checkError(Status, "amd_comgr_action_info_set_option_list");
8283

8384
Status = amd_comgr_do_action(AMD_COMGR_ACTION_COMPILE_SOURCE_TO_RELOCATABLE,

amd/comgr/test/mangled_names_hip_test.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@ int main(int argc, char *argv[]) {
4848
amd_comgr_action_info_t DataAction;
4949
amd_comgr_status_t Status;
5050
size_t Count;
51+
const char *CompileOptions[] = {"-nogpulib", "-nogpuinc"};
52+
size_t CompileOptionsCount =
53+
sizeof(CompileOptions) / sizeof(CompileOptions[0]);
5154

5255
SizeSource = setBuf(TEST_OBJ_DIR "/source1.hip", &BufSource);
5356

@@ -71,6 +74,9 @@ int main(int argc, char *argv[]) {
7174
Status = amd_comgr_action_info_set_isa_name(DataAction,
7275
"amdgcn-amd-amdhsa--gfx900");
7376
checkError(Status, "amd_comgr_action_info_set_isa_name");
77+
Status = amd_comgr_action_info_set_option_list(DataAction, CompileOptions,
78+
CompileOptionsCount);
79+
checkError(Status, "amd_comgr_action_info_set_option_list");
7480

7581
Status = amd_comgr_create_data_set(&DataSetBc);
7682
checkError(Status, "amd_comgr_create_data_set");

amd/comgr/test/name_expression_map_test.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@ int main(int argc, char *argv[]) {
4848
amd_comgr_action_info_t DataAction;
4949
amd_comgr_status_t Status;
5050
size_t Count;
51+
const char *CompileOptions[] = {"-nogpulib", "-nogpuinc"};
52+
size_t CompileOptionsCount =
53+
sizeof(CompileOptions) / sizeof(CompileOptions[0]);
5154

5255
SizeSource = setBuf(TEST_OBJ_DIR "/name-expression.hip", &BufSource);
5356

@@ -71,6 +74,9 @@ int main(int argc, char *argv[]) {
7174
Status = amd_comgr_action_info_set_isa_name(DataAction,
7275
"amdgcn-amd-amdhsa--gfx900");
7376
checkError(Status, "amd_comgr_action_info_set_isa_name");
77+
Status = amd_comgr_action_info_set_option_list(DataAction, CompileOptions,
78+
CompileOptionsCount);
79+
checkError(Status, "amd_comgr_action_info_set_option_list");
7480

7581
Status = amd_comgr_create_data_set(&DataSetBc);
7682
checkError(Status, "amd_comgr_create_data_set");

0 commit comments

Comments
 (0)