Skip to content

Commit 86f7f4c

Browse files
stellaraccidentlucbruni-amd
authored andcommitted
Disable hipcc passing hip-device-libs.
1 parent ed0ed80 commit 86f7f4c

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

amd/hipcc/src/hipBin_amd.h

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -862,15 +862,16 @@ void HipBinAmd::executeHipCCCmd(vector<string> argv) {
862862
}
863863
}
864864

865-
if (hasHIP) {
866-
fs::path bitcodeFs = roccmPath;
867-
bitcodeFs /= "amdgcn/bitcode";
868-
if (deviceLibPath != bitcodeFs.string()) {
869-
string hip_device_lib_str = " --hip-device-lib-path=\""
870-
+ deviceLibPath + "\"";
871-
HIPCXXFLAGS += hip_device_lib_str;
872-
}
873-
}
865+
// Clang knows better how to find its device libs. Let it.
866+
// if (hasHIP) {
867+
// fs::path bitcodeFs = roccmPath;
868+
// bitcodeFs /= "amdgcn/bitcode";
869+
// if (deviceLibPath != bitcodeFs.string()) {
870+
// string hip_device_lib_str = " --hip-device-lib-path=\""
871+
// + deviceLibPath + "\"";
872+
// HIPCXXFLAGS += hip_device_lib_str;
873+
// }
874+
// }
874875

875876
// to avoid using dk linker or MSVC linker
876877
if (isWindows()) {

0 commit comments

Comments
 (0)