Skip to content

Conversation

@LaureBrenot
Copy link
Contributor

Hello,
Here are some improvements of the wct method :

  • bug fix,
  • daily computation to reduce the time per thread in s08compute_wct.py,
  • merge daily npz to nc file with log file track if it stops: s09merge_wct.py,
  • consider dynamic min lag in s08compute_wct.py,
  • consider the new structure (might not be optimized found some inconsistency in existing files between DVV/WCT/WCT and DVV/WCT/DTT),
  • job can end up in 'E'rror instead of 'I'n progress or 'D'one in s08compute_wct.py,
  • can get a ref data of a pair based even if the name of the network is different (optional) in api.py,
  • updated test and command in test.py and msnoise.py,
  • new wct plot script in wct_dvv2.py

Hopefully, no errors are left.

change until main
compute_wcft for day and wct_merge
reset_jobs with E
xr_get_ref even if the period covers different network names
same xr_save_wct function for merge_wct
save_day_wct path structure changed
changes due to structure
new param structure
test wct with new structure
due to structure change
plot wct with new structure
new plot wct command
@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 31.93798% with 878 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.52%. Comparing base (0465494) to head (11cdfe3).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
msnoise/plots/wct_dvv2.py 13.35% 454 Missing ⚠️
msnoise/s09merge_wct.py 14.69% 331 Missing ⚠️
msnoise/s08compute_wct.py 74.05% 82 Missing ⚠️
msnoise/api.py 64.00% 9 Missing ⚠️
msnoise/scripts/msnoise.py 93.54% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0465494) and HEAD (11cdfe3). Click for more details.

HEAD has 144 uploads less than BASE
Flag BASE (0465494) HEAD (11cdfe3)
151 7
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
- Coverage   65.63%   59.52%   -6.12%     
==========================================
  Files          44       46       +2     
  Lines        8529     9674    +1145     
==========================================
+ Hits         5598     5758     +160     
- Misses       2931     3916     +985     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ThomasLecocq
Copy link
Member

Wouw, looks great !! I'll merge & rebase the (yet another) new msnoise 2 branch on top of that !

@ThomasLecocq ThomasLecocq merged commit c80a3c7 into ROBelgium:master Jul 31, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants