Skip to content

Commit 1b8821f

Browse files
committed
Cleanup and bump version
1 parent 0ba57d3 commit 1b8821f

File tree

3 files changed

+10
-16
lines changed

3 files changed

+10
-16
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "node-can-bridge",
3-
"version": "1.0.2",
3+
"version": "1.0.3",
44
"author": "REV Robotics",
55
"description": "Get CAN Data",
66
"license": "MIT",

src/canWrapper.cc

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323

2424
rev::usb::CandleWinUSBDriver* driver = new rev::usb::CandleWinUSBDriver();
2525
std::map<std::string, std::shared_ptr<rev::usb::CANDevice>> CANDeviceMap;
26-
std::map<std::string, uint8_t*> SparkMaxHeartbeatData;
2726
std::set<std::string> devicesRegisteredToHal;
2827
bool halInitialized = false;
2928
uint32_t m_notifier;
@@ -39,7 +38,6 @@ void removeExtraDevicesFromDeviceMap(std::vector<std::string> descriptors) {
3938
}
4039
if (!inDevices) {
4140
CANDeviceMap.erase(itr->first);
42-
SparkMaxHeartbeatData.erase(itr->first);
4341
}
4442
}
4543
}
@@ -50,8 +48,6 @@ bool addDeviceToMap(std::string descriptor) {
5048
std::unique_ptr<rev::usb::CANDevice> canDevice = driver->CreateDeviceFromDescriptor(descriptor_chars);
5149
if (canDevice != nullptr) {
5250
CANDeviceMap[descriptor] = std::move(canDevice);
53-
uint8_t heartbeat[] = {0, 0, 0, 0, 0, 0, 0, 0};
54-
SparkMaxHeartbeatData[descriptor] = heartbeat;
5551
return true;
5652
}
5753
return false;
@@ -600,20 +596,18 @@ void setSparkMaxHeartbeatData(const Napi::CallbackInfo& info) {
600596
std::string descriptor = info[0].As<Napi::String>().Utf8Value();
601597
Napi::Array dataParam = info[1].As<Napi::Array>();
602598

603-
auto heartbeatIterator = SparkMaxHeartbeatData.find(descriptor);
604-
if (heartbeatIterator == SparkMaxHeartbeatData.end()) return;
605-
599+
uint8_t heartbeat[] = {0, 0, 0, 0, 0, 0, 0, 0};
606600
auto deviceIterator = CANDeviceMap.find(descriptor);
607601
if (deviceIterator == CANDeviceMap.end()) return;
608-
_sendCANMessage(descriptor, 0x2052C80, heartbeatIterator->second, 8, -1);
602+
_sendCANMessage(descriptor, 0x2052C80, heartbeat, 8, -1);
609603
std::this_thread::sleep_for(std::chrono::milliseconds(50));
610604

611605
int sum = 0;
612606
for (uint32_t i = 0; i < dataParam.Length(); i++) {
613-
heartbeatIterator->second[i] = dataParam.Get(i).As<Napi::Number>().Uint32Value();
614-
sum+= heartbeatIterator->second[i];
607+
heartbeat[i] = dataParam.Get(i).As<Napi::Number>().Uint32Value();
608+
sum+= heartbeat[i];
615609
}
616610

617-
if (sum == 0) _sendCANMessage(descriptor, 0x2052C80, heartbeatIterator->second, 8, -1);
618-
else _sendCANMessage(descriptor, 0x2052C80, heartbeatIterator->second, 8, 1);
611+
if (sum == 0) _sendCANMessage(descriptor, 0x2052C80, heartbeat, 8, -1);
612+
else _sendCANMessage(descriptor, 0x2052C80, heartbeat, 8, 1);
619613
}

test/test_binding.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ process.on('uncaughtException', function (exception) {
227227
});
228228

229229
testGetDevices()
230-
/*.then(testConcurrentGetDevices)
230+
.then(testConcurrentGetDevices)
231231
.then(testReceiveMessage)
232232
.then(testOpenStreamSession)
233233
.then(testReadStreamSession)
@@ -245,8 +245,8 @@ testGetDevices()
245245
.then(testInitializeNotifier)
246246
.then(testWaitForNotifierAlarm)
247247
.then(testStopNotifier)
248-
.then(testSetThreadPriority)*/
249-
.then(testHeartbeat)
248+
.then(testSetThreadPriority)
249+
/*.then(testHeartbeat)*/
250250
.catch((error) => {
251251
console.log(error);
252252
});

0 commit comments

Comments
 (0)