fix SQALE keys

awful fix…

Author: pawlakm

plugin/src/main/java/com/qualinsight/plugins/sonarqube/smell/plugin/check/BadLoggingSmellCheck.java

@@ -19,7 +19,6 @@
  */
 package com.qualinsight.plugins.sonarqube.smell.plugin.check;
 
-import org.sonar.api.server.rule.RulesDefinition;
 import org.sonar.check.Priority;
 import org.sonar.check.Rule;
 import org.sonar.squidbridge.annotations.SqaleLinearRemediation;
@@ -36,7 +35,7 @@
     "performance"
 })
 @SqaleLinearRemediation(coeff = "1min", effortToFixDescription = "")
-@SqaleSubCharacteristic(value = RulesDefinition.SubCharacteristics.USABILITY_COMPLIANCE)
+@SqaleSubCharacteristic(value = "USABILITY_COMPLIANCE")
 public class BadLoggingSmellCheck extends AbstractSmellCheck {
 
     @Override

plugin/src/main/java/com/qualinsight/plugins/sonarqube/smell/plugin/check/OddballSolutionSmellCheck.java

@@ -19,7 +19,6 @@
  */
 package com.qualinsight.plugins.sonarqube.smell.plugin.check;
 
-import org.sonar.api.server.rule.RulesDefinition;
 import org.sonar.check.Priority;
 import org.sonar.check.Rule;
 import org.sonar.squidbridge.annotations.SqaleLinearRemediation;
@@ -40,7 +39,7 @@
         "design"
     })
 @SqaleLinearRemediation(coeff = "1min", effortToFixDescription = "")
-@SqaleSubCharacteristic(value = RulesDefinition.SubCharacteristics.MAINTAINABILITY_COMPLIANCE)
+@SqaleSubCharacteristic(value = "MAINTAINABILITY_COMPLIANCE")
 public class OddballSolutionSmellCheck extends AbstractSmellCheck {
 
     @Override

plugin/src/main/java/com/qualinsight/plugins/sonarqube/smell/plugin/check/OvercomplicatedAlgorithmSmellCheck.java

@@ -19,7 +19,6 @@
  */
 package com.qualinsight.plugins.sonarqube.smell.plugin.check;
 
-import org.sonar.api.server.rule.RulesDefinition;
 import org.sonar.check.Priority;
 import org.sonar.check.Rule;
 import org.sonar.squidbridge.annotations.SqaleLinearRemediation;
@@ -38,7 +37,7 @@
     "brain-overload"
 })
 @SqaleLinearRemediation(coeff = "1min", effortToFixDescription = "")
-@SqaleSubCharacteristic(value = RulesDefinition.SubCharacteristics.MAINTAINABILITY_COMPLIANCE)
+@SqaleSubCharacteristic(value = "MAINTAINABILITY_COMPLIANCE")
 public class OvercomplicatedAlgorithmSmellCheck extends AbstractSmellCheck {
 
     @Override

plugin/src/main/java/com/qualinsight/plugins/sonarqube/smell/plugin/check/ReinventedWheelSmellCheck.java

@@ -19,7 +19,6 @@
  */
 package com.qualinsight.plugins.sonarqube.smell.plugin.check;
 
-import org.sonar.api.server.rule.RulesDefinition;
 import org.sonar.check.Priority;
 import org.sonar.check.Rule;
 import org.sonar.squidbridge.annotations.SqaleLinearRemediation;
@@ -35,7 +34,7 @@
     "ecosystem"
 })
 @SqaleLinearRemediation(coeff = "1min", effortToFixDescription = "")
-@SqaleSubCharacteristic(value = RulesDefinition.SubCharacteristics.EFFICIENCY_COMPLIANCE)
+@SqaleSubCharacteristic(value = "EFFICIENCY_COMPLIANCE")
 public class ReinventedWheelSmellCheck extends AbstractSmellCheck {
 
     @Override

plugin/src/main/java/com/qualinsight/plugins/sonarqube/smell/plugin/check/SolutionSprawlSmellCheck.java

@@ -19,7 +19,6 @@
  */
 package com.qualinsight.plugins.sonarqube.smell.plugin.check;
 
-import org.sonar.api.server.rule.RulesDefinition;
 import org.sonar.check.Priority;
 import org.sonar.check.Rule;
 import org.sonar.squidbridge.annotations.SqaleLinearRemediation;
@@ -42,7 +41,7 @@
         "brain-overload"
     })
 @SqaleLinearRemediation(coeff = "1min", effortToFixDescription = "")
-@SqaleSubCharacteristic(value = RulesDefinition.SubCharacteristics.EFFICIENCY_COMPLIANCE)
+@SqaleSubCharacteristic(value = "EFFICIENCY_COMPLIANCE")
 public class SolutionSprawlSmellCheck extends AbstractSmellCheck {
 
     @Override

plugin/src/main/java/com/qualinsight/plugins/sonarqube/smell/plugin/check/SpeculativeGeneralitySmellCheck.java

@@ -19,7 +19,6 @@
  */
 package com.qualinsight.plugins.sonarqube.smell.plugin.check;
 
-import org.sonar.api.server.rule.RulesDefinition;
 import org.sonar.check.Priority;
 import org.sonar.check.Rule;
 import org.sonar.squidbridge.annotations.SqaleLinearRemediation;
@@ -41,7 +40,7 @@
         "brain-overload"
     })
 @SqaleLinearRemediation(coeff = "1min", effortToFixDescription = "")
-@SqaleSubCharacteristic(value = RulesDefinition.SubCharacteristics.EFFICIENCY_COMPLIANCE)
+@SqaleSubCharacteristic(value = "EFFICIENCY_COMPLIANCE")
 public class SpeculativeGeneralitySmellCheck extends AbstractSmellCheck {
 
     @Override

plugin/src/main/java/com/qualinsight/plugins/sonarqube/smell/plugin/extension/SmellMetrics.java

@@ -347,8 +347,8 @@ public static final Metric<Number> metricFor(final SmellType type) {
     /**
      * Returns a {@link Metric} from a {@link SmellType}
      *
-     * @param type {@link SmellType} to convert to a metric
-     * @return a {@link Metric} corresponding to the {@link SmellType}
+     * @param metricKey Key to convert to a metric
+     * @return a {@link Metric} corresponding to the key
      */
     @CheckForNull
     public static final Metric<Number> metricFor(final String metricKey) {
@@ -358,7 +358,7 @@ public static final Metric<Number> metricFor(final String metricKey) {
     /**
      * Returns a {@link List} of all {@link Metric}s handled by the Smells plugin.
      *
-     * @return
+     * @return {@link List} of {@link Metric}
      */
     @CheckForNull
     public static final List<Metric<Number>> metrics() {