Skip to content

Commit 5b9f4bc

Browse files
committed
Reduce permissions in workflows
Moved the permissions to the jobs that need them, though this is probably not a big change for the reviewdog workflow. Also drop the `pull-request` permission from the reviewdog workflow, as it's not in the mypy-stubtest one, and still seems to work.
1 parent 3609ca3 commit 5b9f4bc

File tree

4 files changed

+12
-10
lines changed

4 files changed

+12
-10
lines changed

.github/workflows/conflictcheck.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,11 @@ on:
99
pull_request_target:
1010
types: [synchronize]
1111

12-
permissions:
13-
pull-requests: write
14-
1512
jobs:
1613
main:
1714
runs-on: ubuntu-latest
15+
permissions:
16+
pull-requests: write
1817
steps:
1918
- name: Check if PRs have merge conflicts
2019
uses: eps1lon/actions-label-merge-conflict@1b1b1fcde06a9b3d089f3464c96417961dde1168 # v3.0.2

.github/workflows/mypy-stubtest.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,13 @@ on: [pull_request]
44

55
permissions:
66
contents: read
7-
checks: write
87

98
jobs:
109
mypy-stubtest:
1110
name: mypy-stubtest
1211
runs-on: ubuntu-latest
12+
permissions:
13+
checks: write
1314
steps:
1415
- uses: actions/checkout@v4
1516
with:

.github/workflows/pr_welcome.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,11 @@ name: PR Greetings
33

44
on: [pull_request_target]
55

6-
permissions:
7-
pull-requests: write
8-
96
jobs:
107
greeting:
118
runs-on: ubuntu-latest
12-
9+
permissions:
10+
pull-requests: write
1311
steps:
1412
- uses: actions/first-interaction@v1
1513
with:

.github/workflows/reviewdog.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ on: [pull_request]
44

55
permissions:
66
contents: read
7-
checks: write
8-
pull-requests: write
97

108
jobs:
119
flake8:
1210
name: flake8
1311
runs-on: ubuntu-latest
12+
permissions:
13+
checks: write
1414
steps:
1515
- uses: actions/checkout@v4
1616
with:
@@ -38,6 +38,8 @@ jobs:
3838
mypy:
3939
name: mypy
4040
runs-on: ubuntu-latest
41+
permissions:
42+
checks: write
4143
steps:
4244
- uses: actions/checkout@v4
4345
with:
@@ -67,6 +69,8 @@ jobs:
6769
eslint:
6870
name: eslint
6971
runs-on: ubuntu-latest
72+
permissions:
73+
checks: write
7074
steps:
7175
- uses: actions/checkout@v4
7276
with:

0 commit comments

Comments
 (0)