`token_swapper` to return its swaps as `(G::NodeId, G::NodeId)` rather than `NodeIndex`

[jakelishman]

What is the expected enhancement?

This would be a breaking change to the interface, but token_swapper currently returns (NodeIndex, NodeIndex) as its swaps for a graph g: impl NodeIndexable where it's arranged that g.to_index(n.index()) is the way of converting a n: NodeIndex back to the input graph's NodeId.

Given that the mapping of the NodeIndex back to G::NodeId must be possible and known to the token_swapper, it would be more convenient to use if token_swapper returned its answer in this form.

(side note: there's an internal HashMap that tracks this mapping that's unnecessary, given how the inner StableGraph is constructed. (side side note: that mapping needn't be a HashMap and the graph needn't be a StableGraph with holes - could use a compact Graph and a [G::NodeId] as the map back))

[1ucian0]

👋 This issue is part of UnitaryHack 2025. For the duration of the event, it follows a few special rules and considerations:

• No need to be assigned to start working on it, just go ahead! This holds until the end of UnitaryHack.
• If multiple PRs are submitted to close this issue, maintainers may select one at the end of the event and award the bounty accordingly.
• If more than one person works on a single PR, please note that the bounty cannot be split.
• In some cases, a not-fully-complete but close-enough PR might receive a partial bounty.
• If you have any questions or need clarification, feel free to ask in the comments here. Please note that while maintainers do their best to reply, responses might take longer than you expect.

Happy hacking! 🧑‍💻✨

[gluonhiggs]

@jakelishman Is this still open? I'm so confused with the PR appears above. If it is, I will try!

[jakelishman]

The other PR got closed by its author, so it doesn't seem under active work. Even so, I think UnitaryHack allows more than one PR simultaneously, so please feel free.

[gluonhiggs]

@jakelishman I have created the PR as linked above, please have a look! Thank you!

[1ucian0]

🎉 Thanks to everyone who participated in UnitaryHack and contributed to this issue! UnitaryHack 2025 has now concluded, so we're bringing this issue back to its usual workflow. From this point forward:

• Please follow the standard contribution guidelines, including requesting assignment before opening a PR.
• Contributions will be reviewed and merged as part of our regular maintenance cycle.
• Feel free to continue the discussion here if you have ideas or questions.

We appreciate the energy and contributions from the community, thanks for making UnitaryHack a success! 🧑‍💻✨