Skip to content

What all should I solve in a Pull Request? #47

@theSage21

Description

@theSage21

Sometimes it can be difficult to know what all to solve. Multiple issues can be related to each other and sometimes solving one thing can cause other issues and so on. Here are a few guiding principles. They can be broken, but only if a very good reason is there.

A good reason can be "This PR will fix 100 issues together with 1 line of code".

  • fix only one issue in a PR
  • If many issues are related, submit multiple PRs
  • Try to fill out the PR template to the best of your ability
  • If you know this is a work in progress and are not ready for review yet, use WIP: in the title.

There are other guidelines but they only come into picture once the project is large enough. For now this should be ok.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions