bugfix: addItemToKey will call apcu_store() even when the array key already exists (#75)

thedeacon · LKaemmerling · web-flow · commit 5f67192a0bc3 · 2022-04-11T20:52:20.000+02:00
Signed-off-by: Paul Kreiner &lt;github-paul@thedeacon.org&gt;

Co-authored-by: Lukas Kämmerling &lt;lukas.kaemmerling@hetzner-cloud.de&gt;
diff --git a/src/Prometheus/Storage/APCng.php b/src/Prometheus/Storage/APCng.php
@@ -246,8 +246,9 @@ private function addItemToKey(string $key, string $item): void
         if (false === $arr) {
             $arr = [];
         }
-        if (!array_key_exists($item, $arr)) {
-            $arr[$this->encodeLabelKey($item)] = 1;
+        $_item = $this->encodeLabelKey($item);
+        if (!array_key_exists($_item, $arr)) {
+            $arr[$_item] = 1;
             apcu_store($key, $arr);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -246,8 +246,9 @@ private function addItemToKey(string $key, string $item): void`
`246`	`246`	`if (false === $arr) {`
`247`	`247`	`$arr = [];`
`248`	`248`	`}`
`249`		`- if (!array_key_exists($item, $arr)) {`
`250`		`- $arr[$this->encodeLabelKey($item)] = 1;`
	`249`	`+ $_item = $this->encodeLabelKey($item);`
	`250`	`+ if (!array_key_exists($_item, $arr)) {`
	`251`	`+ $arr[$_item] = 1;`
`251`	`252`	`apcu_store($key, $arr);`
`252`	`253`	`}`
`253`	`254`	`}`