Skip to content

Commit 5ee8950

Browse files
committed
fixing tests for php8.4
1 parent 59159b0 commit 5ee8950

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,10 @@ jobs:
3232
env:
3333
# The hostname used to communicate with the Redis service container
3434
REDIS_HOST: redis
35+
REDIS_SENTINEL_HOST: redis-sentinel
3536
# The default Redis port
3637
REDIS_PORT: 6379
38+
REDIS_SENTINEL_PORT: 26379
3739
# MySQL
3840
DB_DATABASE: test
3941
DB_USER: root

src/Prometheus/Storage/Redis.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ public function getRedisSentinel(): \RedisSentinel
130130
* @return self
131131
* @throws StorageException
132132
*/
133-
public static function fromExistingConnection(\Redis $redis, \RedisSentinel $redisSentinel = null): self
133+
public static function fromExistingConnection(\Redis $redis, ?\RedisSentinel $redisSentinel = null): self
134134
{
135135
if (isset($redisSentinel)) {
136136
RedisSentinel::fromExistingConnection($redisSentinel);

0 commit comments

Comments
 (0)