Skip to content

Commit d6e5cc3

Browse files
Merge pull request #4141 from ProjectMirador/fix-workspace-dialog-container
Fix ChangeThemeDialog and WorkspaceImport fullscreen behaviour
2 parents e8d4b64 + f714ac4 commit d6e5cc3

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

src/components/ChangeThemeDialog.jsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const ThemeIcon = styled(PaletteIcon, { name: 'ThemeIcon', slot: 'icon' })(({ th
2121
* a simple dialog providing the possibility to switch the theme
2222
*/
2323
export function ChangeThemeDialog({
24-
handleClose, open = false, selectedTheme, setSelectedTheme, themeIds = [],
24+
container = null, handleClose, open = false, selectedTheme, setSelectedTheme, themeIds = [],
2525
}) {
2626
const { t } = useTranslation();
2727
const handleThemeChange = useCallback((theme) => {
@@ -30,7 +30,7 @@ export function ChangeThemeDialog({
3030
}, [handleClose, setSelectedTheme]);
3131

3232
return (
33-
<WorkspaceDialog onClose={handleClose} open={open} variant="menu">
33+
<WorkspaceDialog container={container} onClose={handleClose} open={open} variant="menu">
3434
<DialogTitle>
3535
{t('changeTheme')}
3636
</DialogTitle>
@@ -57,6 +57,7 @@ export function ChangeThemeDialog({
5757
}
5858

5959
ChangeThemeDialog.propTypes = {
60+
container: PropTypes.object, // eslint-disable-line react/forbid-prop-types
6061
handleClose: PropTypes.func.isRequired,
6162
open: PropTypes.bool,
6263
selectedTheme: PropTypes.string.isRequired,

src/components/WorkspaceImport.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import ScrollIndicatedDialogContent from '../containers/ScrollIndicatedDialogCon
1313
/**
1414
*/
1515
export function WorkspaceImport({
16-
addError, id = undefined, importConfig, classes = {}, handleClose, open = false,
16+
addError, container = null, id = undefined, importConfig, classes = {}, handleClose, open = false,
1717
}) {
1818
const { t } = useTranslation();
1919
const [configImportValue, setConfigImportValue] = useState('');
@@ -39,6 +39,7 @@ export function WorkspaceImport({
3939
return (
4040
<WorkspaceDialog
4141
aria-labelledby={titleId}
42+
container={container}
4243
id={id}
4344
onClose={handleClose}
4445
open={open}
@@ -79,6 +80,7 @@ export function WorkspaceImport({
7980
WorkspaceImport.propTypes = {
8081
addError: PropTypes.func.isRequired,
8182
classes: PropTypes.objectOf(PropTypes.string),
83+
container: PropTypes.object, // eslint-disable-line react/forbid-prop-types
8284
handleClose: PropTypes.func.isRequired,
8385
id: PropTypes.string,
8486
importConfig: PropTypes.func.isRequired,

0 commit comments

Comments
 (0)