Skip to content
This repository was archived by the owner on Jan 20, 2023. It is now read-only.

Commit f5c5fac

Browse files
authored
Merge pull request #12 from k163377/refactor
Refactors.
2 parents 485fc0d + cc438c9 commit f5c5fac

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

src/main/kotlin/com/mapk/krowmapper/KRowMapper.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import org.springframework.jdbc.core.RowMapper
1111

1212
class KRowMapper<T : Any> private constructor(
1313
private val function: KFunctionForCall<T>,
14-
parameterNameConverter: (String) -> String = { it }
14+
parameterNameConverter: (String) -> String
1515
) : RowMapper<T> {
1616
constructor(function: KFunction<T>, propertyNameConverter: (String) -> String = { it }) : this(
1717
KFunctionForCall(function), propertyNameConverter

src/main/kotlin/com/mapk/krowmapper/ParameterForMap.kt

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ internal class ParameterForMap private constructor(
6262
fun getObject(rs: ResultSet): Any? = objectGetter(rs)
6363

6464
companion object {
65-
fun newInstance(param: KParameter, parameterNameConverter: (String) -> String = { it }): ParameterForMap {
65+
fun newInstance(param: KParameter, parameterNameConverter: (String) -> String): ParameterForMap {
6666
return ParameterForMap(
6767
param,
6868
parameterNameConverter(param.getAliasOrName()!!),
@@ -91,18 +91,14 @@ private fun <T : Any> KClass<T>.getDeserializer(): KFunction<T>? {
9191
deserializerFromCompanionObject(this)
9292

9393
return when {
94-
deserializers.isEmpty() -> null
95-
deserializers.size == 1 -> deserializers.single()
94+
deserializers.size <= 1 -> deserializers.singleOrNull()
9695
else -> throw IllegalArgumentException("Find multiple deserializer from $jvmName")
9796
}
9897
}
9998

10099
private fun <T> Collection<KFunction<T>>.getDeserializerFromFunctions(): Collection<KFunction<T>> {
101100
return filter { it.annotations.any { annotation -> annotation is KColumnDeserializer } }
102-
.map { func ->
103-
func.isAccessible = true
104-
func
105-
}
101+
.onEach { it.isAccessible = true }
106102
}
107103

108104
private fun <T : Any> deserializerFromConstructors(clazz: KClass<T>): Collection<KFunction<T>> {

src/test/kotlin/com/mapk/krowmapper/UseDBMappingTest.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,15 @@ import org.h2.jdbcx.JdbcDataSource
66
import org.junit.jupiter.api.AfterAll
77
import org.junit.jupiter.api.Assertions.assertEquals
88
import org.junit.jupiter.api.BeforeAll
9+
import org.junit.jupiter.api.DisplayName
910
import org.junit.jupiter.api.Test
1011
import org.junit.jupiter.api.TestInstance
1112
import org.springframework.jdbc.core.JdbcTemplate
1213
import org.springframework.jdbc.core.namedparam.BeanPropertySqlParameterSource
1314
import org.springframework.jdbc.core.simple.SimpleJdbcInsert
1415

1516
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
17+
@DisplayName("DBを用いてマッピングを行うテスト")
1618
class UseDBMappingTest {
1719
enum class FooStatus {
1820
active, archive, deleted

0 commit comments

Comments
 (0)