Error in batching when using large group support

[Detsieber]

Within a SEPA migration project, I went into a strange issue: Up to the 500th contribution, the batching happened in the order of contribution_recur_id. Starting with the 501st contribution, processing happened in order of the mandate id - which caused some contributions were skipped. (instead of 604 contributions, only 581 were created). (it took me quite some time to isolate that bug...).

As a workaround, I switched off "large groups support", and everything went well.

This might be a bug, that is encountered seldom: In most cases, the id's of contribution_recur and sdd_mandate are in the same order and continuation, so this bug might not appear (I do not know exactly, however). However, in practice, this bug still might cause some contributions getting lost.

(Versions affected: CiviCRM 5.22.1, CiviSEPA 1.4)

[bjendres]

I'll try to have a look at this with 1.5

[bjendres]

I've had a quick look, but this is not the quick fix that I thought. It requires the refactoring of the batching process, because in order to be on the safe side the mandate IDs will have to be extracted upfront, stored in the queue items, and then passed to the batcher. I'll look into this for the next version (1.6)

[Detsieber]

1.6 is okay for me! Thanks for keeping an eye on that issue!