Skip to content

Commit 4a3bc26

Browse files
authored
Merge pull request #279 from yuryleb/fr-grammar-article-fix
Improve article matching in French instructions
2 parents 9de8ca2 + dcdcddb commit 4a3bc26

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ All notable changes to this project will be documented in this file. For change
77
- Added a Japanese localization. [#277](https://github.com/Project-OSRM/osrm-text-instructions/pull/277)
88
- Added an Arabic localization. [#267](https://github.com/Project-OSRM/osrm-text-instructions/pull/267)
99
- Added a Slovenian localization. [#264](https://github.com/Project-OSRM/osrm-text-instructions/pull/264)
10-
- Updated French grammar with 'chaussée' status street name. [#268](https://github.com/Project-OSRM/osrm-text-instructions/pull/268)
10+
- Updated French grammar with 'chaussée' status street name and better articles matching. [#268](https://github.com/Project-OSRM/osrm-text-instructions/pull/268)[#279](https://github.com/Project-OSRM/osrm-text-instructions/pull/279)
1111

1212
## 0.13.2 2018-08-13
1313

languages/overrides/fr.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ var replaces = [
55
[' (le rond-point )?\{rotary_name\}', ' {rotary_name:rotary}'], // eslint-disable-line no-useless-escape
66
[' fin (de )?(la route )?\{way_name\}', ' fin {way_name:preposition}'], // eslint-disable-line no-useless-escape
77
[' \{way_name\}', ' {way_name:article}'], // eslint-disable-line no-useless-escape
8-
[' (à )?\{waypoint_name\}', ' {waypoint_name:arrival}'] // eslint-disable-line no-useless-escape
8+
[' (à +)?\{waypoint_name\}', ' {waypoint_name:arrival}'] // eslint-disable-line no-useless-escape
99
];
1010

1111
function optionize(phrase) {

languages/translations/fr.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
"upcoming": "Vous arriverez à votre {nth} destination, sur la droite",
7878
"short": "Vous êtes arrivé",
7979
"short-upcoming": "Vous arriverez",
80-
"named": "Vous êtes arrivé à {waypoint_name:arrival}, sur la droite"
80+
"named": "Vous êtes arrivé {waypoint_name:arrival}, sur la droite"
8181
},
8282
"sharp left": {
8383
"default": "Vous êtes arrivé à votre {nth} destination, sur la gauche",

test/fixtures/v5/arrive_waypoint_name/right.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"es": "Has llegado a Somewhere, a la derecha",
1616
"es-ES": "Has llegado a Somewhere, a la derecha",
1717
"fi": "Olet saapunut määränpäähän Somewhere, joka on oikealla puolellasi",
18-
"fr": "Vous êtes arrivé à à Somewhere, sur la droite",
18+
"fr": "Vous êtes arrivé à Somewhere, sur la droite",
1919
"he": "הגעת אל Somewhere שלך מימינך",
2020
"hu": "Megérkezett a Somewhere célponthoz, a jobb oldalon",
2121
"id": "Anda telah tiba di Somewhere, di sebelah kanan",

0 commit comments

Comments
 (0)