cache vignette failures

[achubaty]

Error in `preDigest[[whSimList]]$.list`:
! $ operator is invalid for atomic vectors
Backtrace:
    ▆
 1. ├─base::system.time(...)
 2. ├─SpaDES.core::spades(Copy(mySim), cache = TRUE, notOlderThan = Sys.time())
 3. └─SpaDES.core::spades(Copy(mySim), cache = TRUE, notOlderThan = Sys.time())
 4.   └─reproducible::Cache(...)
 5.     └─reproducible:::evalTheFunAndAddChanged(...)
 6.       ├─reproducible::.addChangedAttr(...)
 7.       └─SpaDES.core::.addChangedAttr(...)
 8.         ├─base::unlist(...)
 9.         └─base::lapply(...)

Quitting from iii-cache.Rmd:82-87 [spades]
Execution halted

[achubaty]

also:

Error in `terra::xmin()`:
! no slot of name "pntr" for this object of class "SpatExtent"
Backtrace:
     ▆
  1. ├─base::system.time(...)
  2. ├─SpaDES.core::spades(Copy(mySim), cache = TRUE, notOlderThan = Sys.time())
  3. └─SpaDES.core::spades(Copy(mySim), cache = TRUE, notOlderThan = Sys.time())
  4.   └─reproducible::Cache(...)
  5.     ├─base::withCallingHandlers(...)
  6.     └─reproducible::CacheDigest(...)
  7.       └─base::Map(...)
  8.         └─base::mapply(FUN = f, ..., SIMPLIFY = FALSE)
  9.           └─reproducible (local) `<fn>`(x = dots[[1L]][[1L]], i = dots[[2L]][[1L]])
 10.             ├─base::withCallingHandlers(...)
 11.             ├─reproducible::.robustDigest(x, algo = algo, quick = FALSE, ...)
 12.             └─SpaDES.core::.robustDigest(x, algo = algo, quick = FALSE, ...)
 13.               └─SpaDES.core (local) .local(object, .objects, length, algo, quick, classOptions, ...)
 14.                 ├─reproducible::.robustDigest(...)
 15.                 └─reproducible::.robustDigest(...)
 16.                   └─reproducible (local) .local(object, .objects, length, algo, quick, classOptions, ...)
 17.                     └─base::lapply(...)
 18.                       └─reproducible (local) FUN(X[[i]], ...)
 19.                         ├─reproducible::.robustDigest(...)
 20.                         └─reproducible::.robustDigest(...)
 21.                           └─reproducible (local) .local(object, .objects, length, algo, quick, classOptions, ...)
 22.                             └─base::lapply(...)
 23.                               └─reproducible (local) FUN(X[[i]], ...)
 24.                                 ├─reproducible::.robustDigest(...)
 25.                                 └─reproducible::.robustDigest(...)
 26.                                   └─reproducible (local) .local(object, .objects, length, algo, quick, classOptions, ...)
 27.                                     ├─reproducible::.wrap(object)
 28.                                     └─reproducible:::.wrap.default(object)
 29.                                       ├─terra::xmin(obj)
 30.                                       └─terra::xmin(obj)

Quitting from iii-cache.Rmd:82-87 [spades]
Execution halted

[achubaty]

@eliotmcintire the error in .addChangedAttr appears to be caused by preDigest containing a second list elements of NULLs, triggering an error in this block:

internalSimList <- lapply(preDigest[[whSimList]]$.list, function(x) {
        !any(startsWith(names(x), "doEvent"))
      }) |>
        unlist()
``

```r
> preDigest[[whSimList]]$.list
[[1]]
[[1]]$fireSpread
[[1]]$fireSpread$.isPackage
[1] "9882e97b88564731"

[[1]]$fireSpread$Burn
[1] "e35a8033c2551173"

[[1]]$fireSpread$doEvent.fireSpread
[1] "cf1bd34dac7f63a0"

[[1]]$fireSpread$Init
[1] "4eb6bfa83f803ad5"

[[1]]$fireSpread$Stats
[1] "392ac08e5d8a7da5"


[[1]]$randomLandscapes
[[1]]$randomLandscapes$.isPackage
[1] "9882e97b88564731"

[[1]]$randomLandscapes$doEvent.randomLandscapes
[1] "e75feed8664f5a02"

[[1]]$randomLandscapes$Init
[1] "9d40c5287398d89a"



[[2]]
[[2]][[1]]
NULL

[[2]][[2]]
NULL

Adding the following function and lapplying it to that list removes the empty elements and (I believe) restores the intended functionality:

#' Discard NULL or empty list elements
#'
#' @keywords internal
.discard <- function(x) {
  Filter(Negate(function(p) is.null(p) | length(p) == 0), x)
}

> lapply(preDigest[[whSimList]]$.list, .discard) |> .discard()
[[1]]
[[1]]$fireSpread
[[1]]$fireSpread$.isPackage
[1] "9882e97b88564731"

[[1]]$fireSpread$Burn
[1] "e35a8033c2551173"

[[1]]$fireSpread$doEvent.fireSpread
[1] "cf1bd34dac7f63a0"

[[1]]$fireSpread$Init
[1] "4eb6bfa83f803ad5"

[[1]]$fireSpread$Stats
[1] "392ac08e5d8a7da5"


[[1]]$randomLandscapes
[[1]]$randomLandscapes$.isPackage
[1] "9882e97b88564731"

[[1]]$randomLandscapes$doEvent.randomLandscapes
[1] "e75feed8664f5a02"

[[1]]$randomLandscapes$Init
[1] "9d40c5287398d89a"

This type of fix should be applied upstream, however, in the creation of the preDigest object.

[achubaty]

Likewise, I also see the following stepping through .addChangedAttr:

> postDigest$.list[[whSimList2]]
$landscape
[1] "bf718423918e62cc"

$testStats
[1] "44b158a5ec8cec83"

[[3]]
NULL

[[4]]
NULL

[achubaty]

these point to a problem with .robustDigest upstream in reproducible