Skip to content

Commit 2faa9a1

Browse files
committed
Bump engine and Node.js
Since the shell integration script moved, our minimum supported VS Code version is now 1.94. Also, we don't have to support ADS any more. This also means Electron bumps to 30.x which brings Node.js to 20.x
1 parent 73ff73a commit 2faa9a1

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

docs/development.md

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,7 @@
2525
## Tracking Upstream Dependencies
2626

2727
As a VS Code extension, we first rely on the `engine` field of `package.json` to
28-
state the lowest version of VS Code we support. This extension in particular
29-
must not update past what Azure Data Studio supports, which can be found in the
30-
[`vscodeVersion`][] field of their `product.json` file. We periodically check
31-
that for updates, and when available update our own.
28+
state the lowest version of VS Code we support.
3229

3330
When our `engine` field is updated the development dependency `@types/vscode`
3431
must be updated to match. Note that it uses `~` (not `^`) so as to accept new
@@ -40,8 +37,8 @@ lets us finally update our `@types/node` development dependency to match, our
4037
developer machines if necessary, and the CI and OneBranch pipeline tasks.
4138

4239
[`vscodeVersion`]: https://github.com/microsoft/azuredatastudio/blob/4970733324ef8254b7c22a5dc55af7f8a1dea93f/product.json#L50
43-
[`electron`]: https://github.com/microsoft/vscode/blob/8b617bd08fd9e3fc94d14adb8d358b56e3f72314/package.json#L153
44-
[Electron]: https://www.electronjs.org/blog/electron-25-0
40+
[`electron`]: https://github.com/microsoft/vscode/blob/384ff7382de624fb94dbaf6da11977bba1ecd427/package.json#L159
41+
[Electron]: https://www.electronjs.org/blog/electron-30-0
4542
[Node.js]: https://nodejs.org/en/download/package-manager
4643

4744
### Building the Code

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"publisher": "ms-vscode",
77
"description": "Develop PowerShell modules, commands and scripts in Visual Studio Code!",
88
"engines": {
9-
"vscode": "^1.82.0"
9+
"vscode": "^1.94.0"
1010
},
1111
"author": "Microsoft Corporation",
1212
"license": "SEE LICENSE IN LICENSE.txt",

0 commit comments

Comments
 (0)