new feedback

Author: Andrew

build.ps1

@@ -49,7 +49,7 @@ $filesForWindowsPackage = @(
     'windows_baseline.dsc.yaml',
     'windows_inventory.dsc.yaml'
     'dsc_default.settings.json',
-    'settings.dsc.json'
+    'dsc.settings.json'
 )
 
 $filesForLinuxPackage = @(
@@ -66,7 +66,7 @@ $filesForLinuxPackage = @(
     'RunCommandOnSet.dsc.resource.json',
     'runcommandonset',
     'dsc_default.settings.json',
-    'settings.dsc.json'
+    'dsc.settings.json'
 )
 
 $filesForMacPackage = @(
@@ -83,7 +83,7 @@ $filesForMacPackage = @(
     'RunCommandOnSet.dsc.resource.json',
     'runcommandonset',
     'dsc_default.settings.json',
-    'settings.dsc.json'
+    'dsc.settings.json'
 )
 
 # the list of files other than the binaries which need to be executable

dsc/src/util.rs

@@ -298,9 +298,9 @@ pub fn enable_tracing(trace_level_arg: &Option<TraceLevel>, trace_format_arg: &O
     let mut tracing_setting = TracingSetting::default();
 
     let default_filter = EnvFilter::try_from_default_env()
-        .or_else(|_| EnvFilter::try_new("error"))
+        .or_else(|_| EnvFilter::try_new("warning"))
         .unwrap_or_default()
-        .add_directive(Level::ERROR.into());
+        .add_directive(Level::WARN.into());
     let default_indicatif_layer = IndicatifLayer::new();
     let default_layer = tracing_subscriber::fmt::Layer::default().with_writer(default_indicatif_layer.get_stderr_writer());
     let default_fmt = default_layer

dsc_lib/src/util.rs

@@ -60,6 +60,7 @@ pub fn parse_input_to_json(value: &str) -> Result<String, DscError> {
 
 /// Will search setting files for the specified setting.
 /// Performance implication: Use this function economically as every call opens/reads several config files.
+/// TODO: cache the config
 ///
 /// # Arguments
 ///