Skip to content

Commit 35daf35

Browse files
committed
fix clippy
1 parent faffd5a commit 35daf35

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

dsc_lib/src/discovery/command_discovery.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,7 @@ impl Default for CommandDiscovery {
182182

183183
impl ResourceDiscovery for CommandDiscovery {
184184

185+
#[allow(clippy::too_many_lines)]
185186
fn discover(&mut self, kind: &DiscoveryKind, filter: &str) -> Result<(), DscError> {
186187
info!("{}", t!("discovery.commandDiscovery.discoverResources", filter = filter));
187188

@@ -291,7 +292,7 @@ impl ResourceDiscovery for CommandDiscovery {
291292
match kind {
292293
DiscoveryKind::Resource => {
293294
// Now we need to call discover extensions and add those resource to the list of resources
294-
for (_extension_name, extension) in self.extensions.iter() {
295+
for extension in self.extensions.values() {
295296
if extension.capabilities.contains(&ExtensionCapability::Discover) {
296297
debug!("{}", t!("discovery.commandDiscovery.callingExtension", extension = extension.type_name));
297298
let discovered_resources = extension.discover()?;

dsc_lib/src/extensions/dscextension.rs

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,15 @@ impl DscExtension {
6464
}
6565
}
6666

67+
/// Perform discovery of resources using the extension.
68+
///
69+
/// # Returns
70+
///
71+
/// A result containing a vector of discovered resources or an error.
72+
///
73+
/// # Errors
74+
///
75+
/// This function will return an error if the discovery fails.
6776
pub fn discover(&self) -> Result<Vec<DscResource>, DscError> {
6877
let mut resources: Vec<DscResource> = Vec::new();
6978

@@ -97,11 +106,9 @@ impl DscExtension {
97106
}
98107
};
99108
let manifest_path = Path::new(&discover_result.resource_manifest_path);
109+
// Currently we don't support extensions discovering other extensions
100110
if let ManifestResource::Resource(resource) = load_manifest(manifest_path)? {
101111
resources.push(resource);
102-
} else {
103-
// ignore loading other types of manifests
104-
continue;
105112
}
106113
}
107114
}

0 commit comments

Comments
 (0)