Skip to content

Commit b715cf6

Browse files
authored
Fix BinarySearch type issue in ConvertTo-SourceLineNumber
Merge pull request #132 from mikebijl/fix-binarysearch-type-issue
2 parents 0ade8f4 + d2e2f26 commit b715cf6

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

Source/Public/ConvertTo-SourceLineNumber.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ function ConvertTo-SourceLineNumber {
5858
[PSCustomObject]@{
5959
PSTypeName = "BuildSourceMapping"
6060
SourceFile = $_.Matches[0].Groups["SourceFile"].Value.Trim("'")
61-
StartLineNumber = $_.LineNumber
61+
StartLineNumber = [System.Int32] $_.LineNumber
6262
# This offset is added when calculating the line number
6363
# because of the new line we're adding prior to the content
6464
# of each script file in the built module.

Tests/Public/ConvertTo-SourceLineNumber.Tests.ps1

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ Describe "ConvertTo-SourceLineNumber" {
2020
Pop-Location -StackName ConvertTo-SourceLineNumber
2121
}
2222

23-
2423
It "Should map line <outputLine> in the Module to line <sourceLine> in the source of <sourceFile>" -TestCases $TestCases {
2524
param($outputLine, $sourceFile, $sourceLine)
2625

@@ -79,4 +78,14 @@ Describe "ConvertTo-SourceLineNumber" {
7978
$SourceLocation.SourceLineNumber | Should -Be 5
8079
$SourceLocation.Function | Should -Be 'Get-Source'
8180
}
81+
82+
It 'Should handle type differences correctly' {
83+
$SourceLocation = ConvertTo-SourceLineNumber -SourceFile $Convert_LineNumber_ModulePath -SourceLineNumber ([System.UInt64]48)
84+
$SourceLocation.SourceFile | Should -Be ".${\}Public${\}Get-Source.ps1"
85+
$SourceLocation.SourceLineNumber | Should -Be 5
86+
87+
$SourceLocation = ConvertTo-SourceLineNumber -SourceFile $Convert_LineNumber_ModulePath -SourceLineNumber ([System.Int32]48)
88+
$SourceLocation.SourceFile | Should -Be ".${\}Public${\}Get-Source.ps1"
89+
$SourceLocation.SourceLineNumber | Should -Be 5
90+
}
8291
}

0 commit comments

Comments
 (0)