Fix a few tests that will break if we check module manifests better

Author: Jaykul

Tests/Private/GetBuildInfo.Tests.ps1

@@ -11,8 +11,9 @@ Describe "GetBuildInfo" {
 
     Context "It collects the initial data" {
 
-        New-Item "TestDrive:\MyModule\Source\build.psd1" -Type File -Force
-        New-Item "TestDrive:\MyModule\Source\MyModule.psd1" -Type File -Force
+        # use -Force to create the subdirectories
+        New-Item -Force "TestDrive:\MyModule\Source\build.psd1" -Type File -Value "@{ Path = 'MyModule.psd1' }"
+        New-ModuleManifest "TestDrive:\MyModule\Source\MyModule.psd1" -Author Tester
 
         $Result = InModuleScope -ModuleName ModuleBuilder {
 
@@ -68,18 +69,12 @@ Describe "GetBuildInfo" {
             }} | Should -Throw
         }
 
-        It 'Should throw if the Module manifest does not exists' {
+        It 'Should throw if the Module manifest does not exist' {
+            # use -Force to create the subdirectories
             New-Item -Force TestDrive:\NoModuleManifest\Source\build.psd1 -ItemType File
             {InModuleScope -ModuleName ModuleBuilder {
                     GetBuildInfo -BuildManifest TestDrive:\NoModuleManifest\Source\build.psd1
             }} | Should -Throw
         }
     }
-
-    Context "Invalid module manifest" {
-        # In the current PowerShell 5.1 and 6.1
-        # I can't make Get-Module -ListAvailable throw on a manifest
-        # So I can't test the if($Problems = ... code
-    }
-
 }

Tests/Private/InitializeBuild.Tests.ps1

@@ -4,21 +4,16 @@ Describe "InitializeBuild" {
 
     Context "It collects the initial data" {
 
-        New-Item "TestDrive:\Source\build.psd1" -Type File -Force
-        New-Item "TestDrive:\Source\MyModule.psd1" -Type File -Force
-
-        Set-Content "TestDrive:\Source\MyModule.psd1" '@{
-            RootModule = "MyModule.psm1"
-            Author     = "Test Manager"
-            Version    = "1.0.0"
-        }'
-
         # Note that "Path" is an alias for "SourcePath"
-        Set-Content "TestDrive:\build.psd1" '@{
+        New-Item "TestDrive:\build.psd1" -Type File -Force -Value '@{
             Path = ".\Source\MyModule.psd1"
             SourceDirectories = @("Classes", "Private", "Public")
         }'
 
+        New-Item "TestDrive:\Source\" -Type Directory
+
+        New-ModuleManifest "TestDrive:\Source\MyModule.psd1" -RootModule "MyModule.psm1" -Author "Test Manager" -ModuleVersion "1.0.0"
+
         $Result = @{}
 
         It "Handles Build-Module parameters, and the build.psd1 configuration" {
@@ -35,7 +30,7 @@ Describe "InitializeBuild" {
                     )
                     try {
                         Write-Warning $($MyInvocation.MyCommand | Out-String)
-                        InitializeBuild -SourcePath $SourcePath -Debug
+                        InitializeBuild -SourcePath $SourcePath
                     } catch {
                         $_
                     }
@@ -51,8 +46,8 @@ Describe "InitializeBuild" {
 
         It "Returns the ModuleInfo combined with the BuildInfo" {
             $Result.Name | Should -Be "MyModule"
-            $result.ModuleType | Should -Be "Manifest"
-            (Convert-FolderSeparator $Result.ModuleBase)      | Should -Be (Convert-FolderSeparator "TestDrive:\Source")
+            $Result.SourceDirectories | Should -Be @("Classes", "Private", "Public")
+            (Convert-FolderSeparator $Result.ModuleBase)  | Should -Be (Convert-FolderSeparator "TestDrive:\Source")
             (Convert-FolderSeparator $Result.SourcePath)  | Should -Be (Convert-FolderSeparator "TestDrive:\Source\MyModule.psd1")
         }
 

Tests/Public/Build-Module.Tests.ps1

@@ -531,7 +531,7 @@ Describe "Build-Module" {
     Context "Does not fall over if you build from the drive root" {
 
         $null = New-Item "TestDrive:\build.psd1" -Type File -Force -Value "@{}"
-        $null = New-Item "TestDrive:\MyModule.psd1" -Type File -Force -value '@{ModuleVersion="1.0.0";Author="TEST"}'
+        $null = New-ModuleManifest "TestDrive:\MyModule.psd1" -ModuleVersion "1.0.0" -Author "Tester"
         $null = New-Item "TestDrive:\Public\Test.ps1" -Type File -Value 'MATCHING TEST CONTENT' -Force
 
         Mock GetBuildInfo -ModuleName ModuleBuilder {

azure-pipelines.yml

@@ -10,7 +10,7 @@ resources:
     endpoint: PoshCode
     type: github
     name: PoshCode/Azure-Pipelines
-    ref: refs/tags/3.2.0
+    ref: refs/tags/3.2.1
 
 stages:
 - stage: Build