Skip to content

Clean up libraries #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
6 of 14 tasks
Scrumplex opened this issue Feb 6, 2022 · 9 comments
Open
6 of 14 tasks

Clean up libraries #135

Scrumplex opened this issue Feb 6, 2022 · 9 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Scrumplex
Copy link
Contributor

Scrumplex commented Feb 6, 2022

Currently we have a number of libraries under libraries/. Maybe we can get rid of some or use alternatives. This issue tracks progress on this.

Things to figure out

@txtsd txtsd added the help wanted Extra attention is needed label Feb 7, 2022
@CoelacanthusHex
Copy link

https://github.com/itay-grudev/SingleApplication may be a possible replacement for LocalPeer, but I'm not sure how much LocalPeer modifies from QtSingleapplication. If PloyMC just uses it to implement singleton pattern or instance management, it will be a good choice.

@Scrumplex Scrumplex added this to the 1.2.0 milestone Mar 5, 2022
@Scrumplex Scrumplex modified the milestones: 1.2.0, 1.3.0 Apr 15, 2022
@d-513
Copy link
Contributor

d-513 commented Apr 23, 2022

image
I think this is where hoedown is used, the license screen parses COPYING.md

@txtsd
Copy link
Contributor

txtsd commented Apr 23, 2022

That's ...it? We can probably include that manually. It's not like that file changes much.

@d-513
Copy link
Contributor

d-513 commented Apr 23, 2022

Maybe somewhere else, but I only found this

@flowln
Copy link
Contributor

flowln commented Apr 23, 2022

HoeDown seems to also be used in the FTB modpack selection for displaying the description (not on the legacy one though), as well as in the launcher update dialog (for parsing the changelog). Neither of these i think strictly require having a full-blown markdown parser though, the update dialog we're not using currently, and the FTB one I think we can just make it like the other modpack providers and just display raw text

@Scrumplex
Copy link
Contributor Author

Scrumplex commented Apr 23, 2022

Maybe we don't need to throw out this functionality, but rather just switch to an alternative that we can dynamically link against. Like discount which seems to be widely available (various Linux distros, Homebrew and MSYS2 MinGW)

@txtsd txtsd added the enhancement New feature or request label Apr 30, 2022
@Scrumplex Scrumplex removed this from the 1.3.0 milestone May 20, 2022
@DioEgizio
Copy link
Contributor

Iconfix was removed, but gamemode and murmur2 were added btw

@DioEgizio
Copy link
Contributor

Maybe we don't need to throw out this functionality, but rather just switch to an alternative that we can dynamically link against. Like discount which seems to be widely available (various Linux distros, Homebrew and MSYS2 MinGW)

Btw we won't need any markdown parser if we bump to Qt 5.14/5.15 since https://doc.qt.io/qt-6/qtextdocument.html#setMarkdown

@DioEgizio
Copy link
Contributor

optional-bare has been yeeted btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants