-
Notifications
You must be signed in to change notification settings - Fork 268
Clean up libraries #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
https://github.com/itay-grudev/SingleApplication may be a possible replacement for LocalPeer, but I'm not sure how much LocalPeer modifies from QtSingleapplication. If PloyMC just uses it to implement singleton pattern or instance management, it will be a good choice. |
That's ...it? We can probably include that manually. It's not like that file changes much. |
Maybe somewhere else, but I only found this |
HoeDown seems to also be used in the FTB modpack selection for displaying the description (not on the legacy one though), as well as in the launcher update dialog (for parsing the changelog). Neither of these i think strictly require having a full-blown markdown parser though, the update dialog we're not using currently, and the FTB one I think we can just make it like the other modpack providers and just display raw text |
Maybe we don't need to throw out this functionality, but rather just switch to an alternative that we can dynamically link against. Like discount which seems to be widely available (various Linux distros, Homebrew and MSYS2 MinGW) |
Iconfix was removed, but gamemode and murmur2 were added btw |
Btw we won't need any markdown parser if we bump to Qt 5.14/5.15 since https://doc.qt.io/qt-6/qtextdocument.html#setMarkdown |
optional-bare has been yeeted btw |
Currently we have a number of libraries under
libraries/
. Maybe we can get rid of some or use alternatives. This issue tracks progress on this.Things to figure out
The text was updated successfully, but these errors were encountered: