-
Notifications
You must be signed in to change notification settings - Fork 52
Pluggable Balancers #1680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pluggable Balancers #1680
Conversation
We now have [purescript-cardano-transaction-balancer](https://github.com/mlabs-haskell/purescript-cardano-transaction-balancer) containing the logic for transaction balancing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great. Two things:
- the test
Evaluation with additional UTxOs with native scriptsis failing - A new version of the packaget-set containing the balancer package must be released. Then, update CTL (and the scaffold template) to use it
3f6f0cb to
e35b239
Compare
e35b239 to
4b41b25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default balancer is in the Cardano.Transaction.Balancer AFAIU. But, it sounds too general namespace for me. Instead, it should be something more specific IMO, that describes it better.
c14fbc3 to
848a692
Compare
Closes Move balancer to a separate package with public API #1621
Extracted the default CTL transaction balancer into its own package: CTL Tx Balancing & Coin Selection #2
Pre-review checklist
make format)templates/ctl-scaffold) has been updated## Unreleasedheader, using the appropriate sub-headings (### Added,### Changed,### Removed,### Fixed), and the links to the appropriate issues/PRs have been included