Extract Kupmios provider #1676
Merged
Extract Kupmios provider #1676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusbfs
force-pushed
the
marcusbfs/issue-1662/kupmios-extraction
branch
3 times, most recently
from
9203038 to
aacecdf
Compare
errfrom
requested changes
Mar 13, 2025
CHANGELOG.md
Outdated
| - Switched from WebSocket to HTTP when interfacing with Ogmios. Note: Mempool functionality still uses WebSocket, as it requires a persistent connection to track state. ([#1575](https://github.com/Plutonomicon/cardano-transaction-lib/issues/1575)) | ||
| - Blockfrost Provider has been extracted to a separate package [purescript-cardano-blockfrost-provider](https://github.com/mlabs-haskell/purescript-cardano-blockfrost-provider) using module names in the format `Cardano.Blockfrost.*` ([#1661](https://github.com/Plutonomicon/cardano-transaction-lib/issues/1661)) | ||
| - Kupo + Ogmios Provider has been extracted to a separate package [purescript-cardano-kupmios-provider](https://github.com/mlabs-haskell/purescript-cardano-kupmios-provider) using module names in the format `Cardano.Kupmios.*` ([#1662](https://github.com/Plutonomicon/cardano-transaction-lib/issues/1662)) | ||
| - Ogmios' mempool functionality has been extracted to a separate package [purescript-cardano-ogmios-mempool](https://github.com/mlabs-haskell/purescript-cardano-ogmios-mempool) using the module `Cardano.Ogmios.Mempool`. To use it, the user must create and manage the websocket connection (see [Test.Ctl.Testnet.Contract.OgmiosMempool](https://github.com/Plutonomicon/cardano-transaction-lib/blob/develop/test/Testnet/Contract/OgmiosMempool.purs)) |
There was a problem hiding this comment.
Please use permalinks for source code
There was a problem hiding this comment.
Addressed in 7941ac3.
| let upstream = | ||
| -- https://github.com/mlabs-haskell/purescript-cardano-package-set | ||
| https://raw.githubusercontent.com/mlabs-haskell/purescript-cardano-package-set/v1.2.0/packages.dhall sha256:1879aeee12ef41d5f39ed8b530efa817c747366553b2fc90981ad4e8c21fc5d8 | ||
| https://raw.githubusercontent.com/mlabs-haskell/purescript-cardano-package-set/v1.3.0/packages.dhall |
There was a problem hiding this comment.
Please release cardano-kupmios-provider v1.0.0 and cardano-ogmios-mempool v1.0.0. Our package set should contain versioned dependencies
There was a problem hiding this comment.
Addressed in defd32f.
This module is not used by all projects. If a project needs to use it, it should the [Ogmios Mempool package](https://github.com/mlabs-haskell/purescript-cardano-ogmios-mempool-provider/).
marcusbfs
force-pushed
the
marcusbfs/issue-1662/kupmios-extraction
branch
from
6a633bc to
defd32f
Compare
errfrom
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1662.
Related PRs:
Pre-review checklist
make format)templates/ctl-scaffold) has been updated## Unreleasedheader, using the appropriate sub-headings (### Added,### Changed,### Removed,### Fixed), and the links to the appropriate issues/PRs have been included