Restore onClusterStartup hook for cardano-testnet #1651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errfrom
force-pushed
the
dshuiski/cluster-params
branch
from
4bae6a2 to
fa824a2
Compare
marcusbfs
approved these changes
Apr 25, 2025
There was a problem hiding this comment.
Looks good. Just a gently reminder to update the dependencies after cardano-package-set is released with the latest balancer changes.
|
The test CSL Garbage Collection is failing, and it has happened before and seems to be non-deterministic. I suggest we improve this test: we could introduce a small rolling average (e.g., 3 to 5 samples) to smooth out random spikes and reduce false positives. |
errfrom
force-pushed
the
dshuiski/cluster-params
branch
from
60ae676 to
9f7d480
Compare
errfrom
force-pushed
the
dshuiski/cluster-params
branch
from
56f2d1c to
aa01022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1581
Pre-review checklist
make format)templates/ctl-scaffold) has been updated## Unreleasedheader, using the appropriate sub-headings (### Added,### Changed,### Removed,### Fixed), and the links to the appropriate issues/PRs have been included