comments

Author: sai-deng

circuit-prover/src/batch_stark_prover.rs

@@ -40,10 +40,12 @@ pub struct RowCounts([usize; NUM_TABLES]);
 
 impl RowCounts {
     /// Creates a new RowCounts with the given row counts for each table.
-    pub fn new(rows: [usize; NUM_TABLES]) -> Self {
+    pub const fn new(rows: [usize; NUM_TABLES]) -> Self {
         // Validate that all row counts are non-zero
-        for (i, &count) in rows.iter().enumerate() {
-            assert!(count > 0, "Table {i} has zero rows, which is not supported");
+        let mut i = 0;
+        while i < rows.len() {
+            assert!(rows[i] > 0);
+            i += 1;
         }
         Self(rows)
     }
@@ -73,12 +75,17 @@ pub struct BatchStarkProof<SC>
 where
     SC: MSGC,
 {
+    /// The core cryptographic proof generated by `p3-multi-stark`.
     pub proof: MultiProof<SC>,
-    // Metadata to re-construct AIRs on verifier side.
+    /// Packing configuration used for the Add and Mul tables.
     pub table_packing: TablePacking,
+    /// The number of rows in each of the circuit tables.
     pub rows: RowCounts,
+    /// The degree of the field extension (`D`) used for the proof.
     pub ext_degree: usize,
+    /// The binomial coefficient `W` for extension field multiplication, if `ext_degree > 1`.
     pub w_binomial: Option<MVal<SC>>,
+    /// The configuration for the MMCS table.
     pub mmcs_config: MmcsTableConfig,
 }
 
@@ -241,6 +248,7 @@ where
     where
         EF: Field + BasedVectorSpace<MVal<SC>>,
     {
+        // TODO: Consider parallelizing AIR construction and trace-to-matrix conversions.
         // Build matrices and AIRs per table.
         let packing = self.table_packing;
         let add_lanes = packing.add_lanes();